Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 18 Jul 2012 12:53:00 +0300
From:      =?UTF-8?B?0JLQuNGC0LDQu9C40Lkg0KLRg9GA0L7QstC10YY=?= <corebug@corebug.net>
To:        Eitan Adler <lists@eitanadler.com>
Cc:        FreeBSD Questions List <freebsd-questions@freebsd.org>
Subject:   Re: How to donate code
Message-ID:  <CAKB6gVhX_4fdFd4BTsMbWwjGMjrq=7NJc-DjXwRuwXn97MqiXA@mail.gmail.com>
In-Reply-To: <CAF6rxg=2BbbzA84KOZ=Fg-swHBoH49iW4ko1JrYRJaFSf8UoXA@mail.gmail.com>
References:  <CAKB6gViM0bmNtj75B2PyYxDq3yQ2EvV9GEvHg3HnLVmiE=tWVg@mail.gmail.com> <CAF6rxg=2BbbzA84KOZ=Fg-swHBoH49iW4ko1JrYRJaFSf8UoXA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
2012/7/18 Eitan Adler <lists@eitanadler.com>:
> On 17 July 2012 02:16, =D0=92=D0=B8=D1=82=D0=B0=D0=BB=D0=B8=D0=B9 =D0=A2=
=D1=83=D1=80=D0=BE=D0=B2=D0=B5=D1=86 <corebug@corebug.net> wrote:
>> Hello, colleagues!
>> How would one propose some code to current branch?
>> I've made a little change to ifconfig ( a switch to display IPv4
>> network masks in CIDR format instead of HEX) and want to suggest this
>> change to FreeBSD project.
>> Also i've created a PR with my patch describing what is done and for
>> what (http://www.freebsd.org/cgi/query-pr.cgi?pr=3D169072&cat=3D), but
>> maybe there's some other way to somehow push this code for review by
>> FreeBSD developers?
>> Thank you a lot and sorry for noobish question :)
>
> The general advice is mail the patch to -hackers for review. If you
> don't get a reply or if people like it, submit a PR so it doesn't get
> lost. Be aware that the latency for some patches could be longer than
> you expect. :(

I already realize that :(

> FWIW "unified diff" format patches are much preferred. (diff -u)

Okay, i'll rewrite this code under -current OS build and mail the
"unified diff" patch to -hackers list.
Thank you all people!

>
> --
> Eitan Adler



--=20




~~~
WBR,
Vitaliy Turovets
Systems Administrator
Corebug.Net
+38(093)265-70-55
VITU-RIPE
X-NCC-RegID: ua.tv



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKB6gVhX_4fdFd4BTsMbWwjGMjrq=7NJc-DjXwRuwXn97MqiXA>