Date: Tue, 31 Aug 2010 01:28:03 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Kostik Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r211982 - head/sbin/hastd Message-ID: <20100830232803.GH1871@garage.freebsd.pl> In-Reply-To: <20100830075945.GS2396@deviant.kiev.zoral.com.ua> References: <201008300006.o7U065Nu078151@svn.freebsd.org> <20100830075945.GS2396@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--GlnCQLZWzqLRJED8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 30, 2010 at 10:59:45AM +0300, Kostik Belousov wrote: > On Mon, Aug 30, 2010 at 12:06:05AM +0000, Pawel Jakub Dawidek wrote: > > Author: pjd > > Date: Mon Aug 30 00:06:05 2010 > > New Revision: 211982 > > URL: http://svn.freebsd.org/changeset/base/211982 > >=20 > > Log: > > Use sigtimedwait(2) for signals handling in primary process. > > This fixes various races and eliminates use of pthread* API in signal= handler. >=20 > Replying to the random commit. >=20 > In the multithreaded process, after the fork in the child, you shall > not call any not async-signal safe functions. I suppose that hook_execv() > exposes the issue, calling into some stdio functions and sysconf(). Right. It should be fixed it in r212038. Now all the hooks are executed from the main (non-threaded) process. This also makes it easier to drop privs in the worker processes in the future, now that we don't execute anything from them. Thanks for pointing that out. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --GlnCQLZWzqLRJED8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkx8PoIACgkQForvXbEpPzRgjACgxouY3EPKScws4IQGPMSPuagc vlQAoNlTU0Hkcaunc+Le6y3yr9jhGqgo =g1Ws -----END PGP SIGNATURE----- --GlnCQLZWzqLRJED8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100830232803.GH1871>