Date: Thu, 21 Jul 2005 09:15:30 -0700 From: Maksim Yevmenkin <maksim.yevmenkin@savvis.net> To: Eric Anderson <anderson@centtech.com> Cc: freebsd-bluetooth@freebsd.org Subject: Re: bthidd causes panic on recent -current (7.0) Message-ID: <42DFCA22.5080007@savvis.net> In-Reply-To: <42DFC4B1.9010301@centtech.com> References: <42DFC4B1.9010301@centtech.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------020404050306040302040702 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Eric, > I recently cvsupped, and rebuilt world/kernel. After booting up, I > panic when bthidd runs. thanks for the report. the problem is not bthidd(8), its vkbd(4). i made a typo and did not properly initialize mutex (missed name). the patch is attached. thanks, max --------------020404050306040302040702 Content-Type: text/plain; name="vkbd.c.diff.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="vkbd.c.diff.txt" Index: vkbd.c =================================================================== RCS file: /usr/local/cvs/sys/dev/vkbd/vkbd.c,v retrieving revision 1.22 diff -u -r1.22 vkbd.c --- vkbd.c 23 Jun 2005 00:30:37 -0000 1.22 +++ vkbd.c 21 Jul 2005 16:11:15 -0000 @@ -65,7 +65,7 @@ *****************************************************************************/ #define VKBD_LOCK_DECL struct mtx ks_lock -#define VKBD_LOCK_INIT(s) mtx_init(&(s)->ks_lock, NULL, NULL, MTX_DEF) +#define VKBD_LOCK_INIT(s) mtx_init(&(s)->ks_lock, "vkbd_lock", NULL, MTX_DEF|MTX_RECURSE) #define VKBD_LOCK_DESTROY(s) mtx_destroy(&(s)->ks_lock) #define VKBD_LOCK(s) mtx_lock(&(s)->ks_lock) #define VKBD_UNLOCK(s) mtx_unlock(&(s)->ks_lock) --------------020404050306040302040702--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?42DFCA22.5080007>