Date: Sat, 24 Oct 2015 16:26:50 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Don Lewis <truckman@FreeBSD.org> Cc: kris@pcbsd.org, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, kmoore@FreeBSD.org, ports-committers@freebsd.org Subject: Re: svn commit: r400121 - head/net-im/teamwords Message-ID: <20151024162650.GA30677@FreeBSD.org> In-Reply-To: <201510241621.t9OGLm4A003033@gw.catspoiler.org> References: <20151024154100.GA2659@FreeBSD.org> <201510241621.t9OGLm4A003033@gw.catspoiler.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Oct 24, 2015 at 09:21:48AM -0700, Don Lewis wrote:
> On 24 Oct, Alexey Dokuchaev wrote:
> > As for stripping binaries explicitly in the Makefile: I'm actually against
> > it; it made sense in pre-staging times when we've been installing stuff
> > directly into user's filesystem, but now with staging we ideally should be
> > just dumping unstripped binaries to staging area, and stripping should be
> > done upon "make install" by the framework. Those ${STRIP_CMD}'s just make
> > Makefiles more imperative and hard to control. Think of what would I have
> > to do if I want to build debug package? -- patching individual ports on an
> > ad-hoc basis in many little places instead of setting some universal knob
> > like NO_STRIP in /etc/make.conf or something.
>
> Debug builds set ${STRIP_CMD} to /bin/true. From bsd.port.mk: [...]
Ah yes, I somehow missed this part. OK, that explains why we can still
leave with this imperativeness; thanks for bringing this up Don.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151024162650.GA30677>