Date: Mon, 3 Dec 2001 11:40:32 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: Garrett Wollman <wollman@khavrinen.lcs.mit.edu> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_mroute.c ip_output.c Message-ID: <20011203114032.C60143@sunbay.com> In-Reply-To: <200112012051.fB1KpAp47152@khavrinen.lcs.mit.edu> References: <200112011348.fB1DmGf07402@freefall.freebsd.org> <200112012051.fB1KpAp47152@khavrinen.lcs.mit.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Dec 01, 2001 at 03:51:10PM -0500, Garrett Wollman wrote: > <<On Sat, 1 Dec 2001 05:48:16 -0800 (PST), Ruslan Ermilov <ru@FreeBSD.org> said: > > > Allow for ip_output() to be called with a NULL route pointer. > > This fixes a panic I introduced yesterday in ip_icmp.c,v 1.64. > > I think this fix is a bug. I want to require all callers of > ip_output() to already have either a route or an interface (iff > routing is disabled). > Actually, I just followed the BSD/OS, NetBSD and OpenBSD here, which all accept ro == NULL meaning ip_output() looks the route up itself. I don't see anything wrong here, and it also reduces the code bloat. Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011203114032.C60143>