Date: Sat, 16 Jul 2011 16:30:13 GMT From: Chris Rees <crees@freebsd.org> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/158179: some packages do not fully honor -P dir option in pkg_add(1) Message-ID: <201107161630.p6GGUDRs089772@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/158179; it has been noted by GNATS. From: Chris Rees <crees@freebsd.org> To: Stephen Montgomery-Smith <stephen@missouri.edu> Cc: "freebsd@sopwith.solgatos.com" <freebsd@sopwith.solgatos.com>, "bug-followup@freebsd.org" <bug-followup@freebsd.org>, Stefan Bethke <stb@lassitu.de>, FreeBSD Ports <freebsd-ports@freebsd.org> Subject: Re: ports/158179: some packages do not fully honor -P dir option in pkg_add(1) Date: Sat, 16 Jul 2011 17:21:12 +0100 --bcaec5431e908ca63204a832274a Content-Type: text/plain; charset=ISO-8859-1 On 16 Jul 2011 17:18, "Stephen Montgomery-Smith" <stephen@missouri.edu> wrote: > > current@ to ports@ again. (Sorry, my mistake.) > > > On 07/16/2011 11:10 AM, Chris Rees wrote: >> >> >> On 16 Jul 2011 17:04, "Stephen Montgomery-Smith" <stephen@missouri.edu >> <mailto:stephen@missouri.edu>> wrote: >> > >> > On 07/16/2011 10:53 AM, Chris Rees wrote: >> >> >> >> >> >> On 16 Jul 2011 16:38, "Stephen Montgomery-Smith" >> <stephen@missouri.edu <mailto:stephen@missouri.edu> >> >> <mailto:stephen@missouri.edu <mailto:stephen@missouri.edu>>> wrote: >> >> > For example, suppose the C source code contains something like: >> >> > char applications_dir = "/usr/local/share/applications"; >> >> > and this is filled in by the ./configure script. >> >> > >> >> > How is that handled? >> >> > >> >> >> >> It's not. >> >> >> >> Remember what a package is, literally the files from the plist tarred >> >> with some magic +FILEs and the pkg-*install files- if paths are >> >> hardcoded in objects that's how it'll be installed. >> > >> > >> > What if some of the installation programs are binaries, and >> "/usr/local" is hard coded into installation binaries or scripts >> provided by the software itself. >> >> Sorry, poor wording on my part. > > > No, I didn't read what you said properly. > > >> If it was compiled as prefix=/usr/local, that's how it'll be installed, >> regardless of your -p argument. > > > So "-p" and "-P" are inherently buggy, and should be removed from pkg_add? > > (Or every port which uses prefix=/usr/local needs major revision and patching, which I think is an intolerable workload.) They are only for internal and experimental use really anyway. Perhaps the manpage should mention that. Bear in mind they should work fine if the port doesn't hardcode absolute paths. Chris --bcaec5431e908ca63204a832274a Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable <p><br> On 16 Jul 2011 17:18, "Stephen Montgomery-Smith" <<a href=3D"m= ailto:stephen@missouri.edu">stephen@missouri.edu</a>> wrote:<br> ><br> > current@ to ports@ again. =A0(Sorry, my mistake.)<br> ><br> ><br> > On 07/16/2011 11:10 AM, Chris Rees wrote:<br> >><br> >><br> >> On 16 Jul 2011 17:04, "Stephen Montgomery-Smith" <<a = href=3D"mailto:stephen@missouri.edu">stephen@missouri.edu</a><br> >> <mailto:<a href=3D"mailto:stephen@missouri.edu">stephen@missour= i.edu</a>>> wrote:<br> >> =A0><br> >> =A0> On 07/16/2011 10:53 AM, Chris Rees wrote:<br> >> =A0>><br> >> =A0>><br> >> =A0>> On 16 Jul 2011 16:38, "Stephen Montgomery-Smith&q= uot;<br> >> <<a href=3D"mailto:stephen@missouri.edu">stephen@missouri.edu</= a> <mailto:<a href=3D"mailto:stephen@missouri.edu">stephen@missouri.edu<= /a>><br> >> =A0>> <mailto:<a href=3D"mailto:stephen@missouri.edu">ste= phen@missouri.edu</a> <mailto:<a href=3D"mailto:stephen@missouri.edu">st= ephen@missouri.edu</a>>>> wrote:<br> >> =A0>> > For example, suppose the C source code contains s= omething like:<br> >> =A0>> > char applications_dir =3D "/usr/local/share/= applications";<br> >> =A0>> > and this is filled in by the ./configure script.<= br> >> =A0>> ><br> >> =A0>> > How is that handled?<br> >> =A0>> ><br> >> =A0>><br> >> =A0>> It's not.<br> >> =A0>><br> >> =A0>> Remember what a package is, literally the files from t= he plist tarred<br> >> =A0>> with some magic +FILEs and the pkg-*install files- if = paths are<br> >> =A0>> hardcoded in objects that's how it'll be insta= lled.<br> >> =A0><br> >> =A0><br> >> =A0> What if some of the installation programs are binaries, an= d<br> >> "/usr/local" is hard coded into installation binaries or= scripts<br> >> provided by the software itself.<br> >><br> >> Sorry, poor wording on my part.<br> ><br> ><br> > No, I didn't read what you said properly.<br> ><br> ><br> >> If it was compiled as prefix=3D/usr/local, that's how it'l= l be installed,<br> >> regardless of your -p argument.<br> ><br> ><br> > So "-p" and "-P" are inherently buggy, and should = be removed from pkg_add?<br> ><br> > (Or every port which uses prefix=3D/usr/local needs major revision and= patching, which I think is an intolerable workload.)</p> <p>They are only for internal and experimental use really anyway. Perhaps t= he manpage should mention that.</p> <p>Bear in mind they should work fine if the port doesn't hardcode abso= lute paths.</p> <p>Chris</p> --bcaec5431e908ca63204a832274a--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201107161630.p6GGUDRs089772>