Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 28 Jun 2000 11:31:55 +1000 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        Alexander Langer <alex@big.endian.de>
Cc:        Clive Lin <clive@CirX.ORG>, FreeBSD current <current@FreeBSD.ORG>
Subject:   Re: let badsect recog IFCHR in 5.0-C
Message-ID:  <Pine.BSF.4.21.0006281129310.7042-100000@besplex.bde.org>
In-Reply-To: <20000627173821.A98097@cichlids.cichlids.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 27 Jun 2000, Alexander Langer wrote:

> Thus spake Clive Lin (clive@CirX.ORG):
> 
> > -	memcpy(name_dir_end + 1, name_dir_end, strlen(name_dir_end) + 1);
> > -	*name_dir_end = 'r';
> > +	// un-needed.
> > +	// memcpy(name_dir_end + 1, name_dir_end, strlen(name_dir_end) + 1);
> > +	// *name_dir_end = 'r';
> 
> Use /* */ comments or #if 0.
> 
> Please see style(9) :)

1) Don't "comment out" dead code.  Remove it.
2) Use only #if 0 to "comment out code.  Comments are unsuitable for
   "commenting out" code in general, because the code might contain
   comments, and they are harder to edit and read.

Bruce



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0006281129310.7042-100000>