Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 13 May 2016 14:59:02 +0000 (UTC)
From:      "Pedro F. Giffuni" <pfg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r299676 - head/usr.sbin/bhyve
Message-ID:  <201605131459.u4DEx2RD084301@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: pfg
Date: Fri May 13 14:59:02 2016
New Revision: 299676
URL: https://svnweb.freebsd.org/changeset/base/299676

Log:
  bhyve: consider the bogus case of a negative bar idx.
  
  This is a followup to r297472 to squelch Coverity.
  
  CID:	1194319

Modified:
  head/usr.sbin/bhyve/pci_emul.c

Modified: head/usr.sbin/bhyve/pci_emul.c
==============================================================================
--- head/usr.sbin/bhyve/pci_emul.c	Fri May 13 14:38:04 2016	(r299675)
+++ head/usr.sbin/bhyve/pci_emul.c	Fri May 13 14:59:02 2016	(r299676)
@@ -2034,7 +2034,7 @@ pci_emul_diow(struct vmctx *ctx, int vcp
 		 */
 	}
 
-	if (baridx > 2) {
+	if (baridx > 2 || baridx < 0) {
 		printf("diow: unknown bar idx %d\n", baridx);
 	}
 }
@@ -2089,7 +2089,7 @@ pci_emul_dior(struct vmctx *ctx, int vcp
 	}
 
 
-	if (baridx > 2) {
+	if (baridx > 2 || baridx < 0) {
 		printf("dior: unknown bar idx %d\n", baridx);
 		return (0);
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201605131459.u4DEx2RD084301>