Date: Wed, 07 Sep 2011 09:28:11 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: rmacklem@uoguelph.ca Cc: kostikbel@gmail.com, pjd@FreeBSD.org, current@FreeBSD.org, kaduk@MIT.EDU Subject: Re: fsid change of ZFS? Message-ID: <20110907.092811.150809864009161842.hrs@allbsd.org> In-Reply-To: <468764384.310026.1314219682612.JavaMail.root@erie.cs.uoguelph.ca> References: <20110824200813.GC1688@garage.freebsd.pl> <468764384.310026.1314219682612.JavaMail.root@erie.cs.uoguelph.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Wed_Sep__7_09_28_11_2011_453)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hi Rick, Rick Macklem <rmacklem@uoguelph.ca> wrote in <468764384.310026.1314219682612.JavaMail.root@erie.cs.uoguelph.ca>: rm> It sounds like people have agreed that this is a reasonable solution. rm> If hrs@ can confirm that testing shows it fixes the original problem rm> (the ZFS file handles don't change when it's loaded at different times), rm> I'll pass it along to re@. I am sorry for the delay, but I tried the patch on several boxes and it worked fine: [old (fixed array) patch] % lsvfs Filesystem Num Refs Flags -------------------------------- --- ----- --------------- ufs 2 3 oldnfs 15 0 network zfs 7 4 jail, delegated-administration nfs 6 1 network cd9660 1 0 read-only procfs 3 0 synthetic devfs 4 1 synthetic msdosfs 5 0 [new (hash-based) patch] Filesystem Num Refs Flags -------------------------------- --- ----- --------------- ufs 53 3 oldnfs 77 0 network zfs 222 4 jail, delegated-administration nfs 58 0 network cd9660 189 0 read-only procfs 2 0 synthetic devfs 113 1 synthetic msdosfs 50 0 [new patch, different loading order of kld modules] Filesystem Num Refs Flags -------------------------------- --- ----- --------------- ufs 53 3 zfs 222 4 jail, delegated-administration cd9660 189 0 read-only procfs 2 0 synthetic devfs 113 1 synthetic msdosfs 50 0 nfs 58 0 network Thanks a lot for the patch. I think it should be committed before 9.0R is released. Even for 8-STABLE this is useful but there is a problem that it will make an incomptibility of the fsid calculation between 8.N and 8.(N+1). What do you think about adding a loader tunable (something like vfs.fsidhash) to control this and making it disable by default? It would help sysadmins who will try a upgrade from 8.X to 9.X in the future, I think. -- Hiroki ----Security_Multipart(Wed_Sep__7_09_28_11_2011_453)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAk5mupsACgkQTyzT2CeTzy11NACgsxhBGpFMFBnABkdXYolF7VjG NOQAnRw05VDLvn2SH+4+PEJCPvqRuTOg =Ouve -----END PGP SIGNATURE----- ----Security_Multipart(Wed_Sep__7_09_28_11_2011_453)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110907.092811.150809864009161842.hrs>