Date: Fri, 08 Jul 2005 21:37:22 -0600 From: Scott Long <scottl@samsco.org> To: Maxim Sobolev <sobomax@portaone.com> Cc: Roman Kurakin <rik@FreeBSD.org>, cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/ndis subr_ntoskrnl.c Message-ID: <42CF4672.2090204@samsco.org> In-Reply-To: <20050709033317.GA64401@www.portaone.com> References: <200507081837.j68Ib0IM082223@repoman.freebsd.org> <42CECCD8.5070201@portaone.com> <42CEEF12.4070904@samsco.org> <20050709033317.GA64401@www.portaone.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Maxim Sobolev wrote: > On Fri, Jul 08, 2005 at 03:24:34PM -0600, Scott Long wrote: > >>>I think the better fix is to change type of k_lock member from void* to >>>the struct mtx*, I've already commited such change to the RELENG_5 few >>>days ago. >>> >>>-Maxim >> >>It's a void* for portability with other OS's. This work has already >>been ported >>to Solaris, and maybe even other OS's by now. Reducing the portability is a >>bad idea, and will likely get you smacked around by Bill when he >>notices. I'd >>highly recommend not doing this again in the future. > > > Even if so, rik's version is no better since it adds explicit cast > (two of them in fact) to struct mtx*. Either way it will break > portability with other OSes. Therefore, they are on par, but my > solution is more clear wrt FreeBSD. > > -Maxim subr_ntoskrnl.c explicitely uses the FreeBSD mtx API, so adding FreeBSD casts is fine. Polluting the common headers, as you did, is not the same thing. Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?42CF4672.2090204>