Date: Tue, 3 Jul 2001 01:50:03 -0700 (PDT) From: Bruce Evans <bde@zeta.org.au> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/28628: small indentation change to /sys/kern/kern_sysctl.c Message-ID: <200107030850.f638o3G67426@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/28628; it has been noted by GNATS. From: Bruce Evans <bde@zeta.org.au> To: Dima Dorfman <dima@unixfreak.org> Cc: freebsd-gnats-submit@FreeBSD.ORG Subject: Re: kern/28628: small indentation change to /sys/kern/kern_sysctl.c Date: Tue, 3 Jul 2001 18:39:18 +1000 (EST) On Mon, 2 Jul 2001, Dima Dorfman wrote: > Giorgos Keramidas <keramida@ceid.upatras.gr> writes: > > Index: kern_sysctl.c > > =================================================================== > > RCS file: /home/ncvs/src/sys/kern/kern_sysctl.c,v > > retrieving revision 1.110 > > diff -c -t -r1.110 kern_sysctl.c > > *** kern_sysctl.c 2001/06/22 19:54:38 1.110 > > --- kern_sysctl.c 2001/07/02 09:11:51 > > *************** > > *** 1027,1033 **** > > if (!(oid->oid_kind & CTLFLAG_ANYBODY) && > > req->newptr && req->p && > > (error = suser_xxx(0, req->p, > > ! (oid->oid_kind & CTLFLAG_PRISON) ? PRISON_ROOT : 0))) > > return (error); > > > > if (!oid->oid_handler) > > --- 1027,1034 ---- > > if (!(oid->oid_kind & CTLFLAG_ANYBODY) && > > req->newptr && req->p && > > (error = suser_xxx(0, req->p, > > ! (oid->oid_kind & CTLFLAG_PRISON) ? PRISON_ROOT : 0))) > > ! > > return (error); > > This change introduces two style bugs: (1) secondary indents are four, > not eight spaces, and (2) lines should be <= 80 characters. > Obviously, fixing (1) will fix (2) as well. The fix is null since the secondary indent is already 4. This gives code that is not very easy to read in this case, especially if you are not used to the secondary indent rule, but the alternatives are not much better. > That said, I don't think > it makes sense to file PRs for minor style fixes. There are a lot I agree. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200107030850.f638o3G67426>