Date: Thu, 04 Jul 2013 01:53:56 +0200 From: Niclas Zeising <zeising@daemonic.se> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: vbox@freebsd.org, AN <andy@neu.net>, "scottl@FreeBSD.org" <scottl@freebsd.org>, freebsd-ports@freebsd.org Subject: Re: !virtualbox-ose (virtualbox-ose-4.2.14) (bad C++ code) Message-ID: <51D4B994.7050207@daemonic.se> In-Reply-To: <51D4B7CE.5010405@FreeBSD.org> References: <alpine.BSF.2.00.1307031334450.82358@mail.neu.net> <51D4662E.9050503@FreeBSD.org> <51D4B5C9.8070809@daemonic.se> <51D4B7CE.5010405@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07/04/13 01:46, Jung-uk Kim wrote: > On 2013-07-03 19:37:45 -0400, Niclas Zeising wrote: >> On 07/03/13 19:58, Jung-uk Kim wrote: >>> On 2013-07-03 13:38:46 -0400, AN wrote: >>>> FreeBSD FBSD10 10.0-CURRENT FreeBSD 10.0-CURRENT #73 r252430: >>>> Sun Jun 30 17:30:59 CDT 2013 >>>> root@FBSD10:/usr/obj/usr/src/sys/MYKERNEL amd64 >>> >>>> VBox upgrade fails. >>> >>> >>> >>>> In file included from >>>> /usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.2.14/src/VBox/Devices/Storage/DrvHostBase.cpp:105: >>> >>>> >>>> > /usr/include/cam/cam_ccb.h: In function 'cam_status >>>> cam_ccb_status(ccb*)': /usr/include/cam/cam_ccb.h:1309: error: >>>> invalid conversion from 'unsigned int' to 'cam_status' >>> ... >>> >>> This problem was introduced with r252382. Basically, C >>> compilers don't complain about this implicit casting but C++ >>> compilers do not like it at all. Luckily, it is easy to fix. >>> Please see the attached patch. > >> Hi! I'm getting a similar error when compiling >> sysutils/smartmontools, however your proposed patch does not work, >> at least not when compiling with clang. > > It works for me, for both clang++ and g++ on head. I tried > sysutils/smartmontools, too. Are you sure you have the new header > file in /usr/include/cam? ;-) At this hour I'm not sure of anything ;) If I put the correct parenthesis everywhere, it certainly works better. Sorry for the noise. -- Niclas Zeising
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51D4B994.7050207>