Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 24 Jun 2006 18:35:09 +0200 (CEST)
From:      Thomas-Martin Seck <tmseck@netcologne.de>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/99426: [Maintainer] mail/usendmail: define regression-test target, fix pkg-message substitution
Message-ID:  <200606241635.k5OGZ9cj051943@hardy.tmseck.homedns.org>
Resent-Message-ID: <200606241640.k5OGeIfH075109@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         99426
>Category:       ports
>Synopsis:       [Maintainer] mail/usendmail: define regression-test target, fix pkg-message substitution
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jun 24 16:40:17 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Thomas-Martin Seck
>Release:        FreeBSD 6.1-STABLE i386
>Organization:
a private site in Germany
>Environment:
FreeBSD ports collection as of June 24, 2006.

	
>Description:
Cleanup the way we build the port:

- pass 'make all' verbatim to the package instead of calling the
  package's scripts manually
- define a regression-test target depending on build: that runs the
  package's test script in order to automate regression testing
  on the ports cluster
- belatedly change QMAIL_DIR to QMAIL_PREFIX in files/pkg-message.in, too
	
>How-To-Repeat:
	
>Fix:
Apply this patch:

Index: files/pkg-message.in
===================================================================
--- files/pkg-message.in	(.../mail/usendmail)	(revision 910)
+++ files/pkg-message.in	(.../local/usendmail)	(revision 910)
@@ -7,8 +7,8 @@
 
 in /etc/mail/mailer.conf replace the lines
 
-sendmail	%%QMAIL_DIR%%/bin/sendmail
-send-mail	%%QMAIL_DIR%%/bin/sendmail
+sendmail	%%QMAIL_PREFIX%%/bin/sendmail
+send-mail	%%QMAIL_PREFIX%%/bin/sendmail
 
 with
 
@@ -16,5 +16,5 @@
 send-mail	%%PREFIX%%/sbin/usendmail
 
 Otherwise replace the link from /usr/sbin/sendmail to
-%%QMAIL_DIR%%/bin/sendmail with one to %%PREFIX%%/sbin/usendmail.
+%%QMAIL_PREFIX%%/bin/sendmail with one to %%PREFIX%%/sbin/usendmail.
 
Index: Makefile
===================================================================
--- Makefile	(.../mail/usendmail)	(revision 910)
+++ Makefile	(.../local/usendmail)	(revision 910)
@@ -30,8 +30,8 @@
 	@${REINPLACE_CMD} -e 's,^CC=,CC\?=,' \
 	    ${WRKSRC}/src/Makefile
 
-do-build:
-	cd ${WRKSRC} && ./package/build
+regression-test: build
+	cd ${WRKSRC} && ./package/check
 
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/command/usendmail ${PREFIX}/sbin/
	


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200606241635.k5OGZ9cj051943>