Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 31 Aug 2010 08:24:19 +0200
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        David Xu <davidxu@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r211982 - head/sbin/hastd
Message-ID:  <20100831062419.GK1871@garage.freebsd.pl>
In-Reply-To: <4C7CD808.3060903@freebsd.org>
References:  <201008300006.o7U065Nu078151@svn.freebsd.org> <4C7CD808.3060903@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--RNRUMt0ZF5Yaq/Aq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Aug 31, 2010 at 10:23:04AM +0000, David Xu wrote:
> Pawel Jakub Dawidek wrote:
> >Author: pjd
> >Date: Mon Aug 30 00:06:05 2010
> >New Revision: 211982
> >URL: http://svn.freebsd.org/changeset/base/211982
> >
> >Log:
> >  Use sigtimedwait(2) for signals handling in primary process.
> >  This fixes various races and eliminates use of pthread* API in signal=
=20
> >  handler.
> > =20
> >  Pointed out by:	kib
> >  With help from:	jilles
> >  MFC after:	2 weeks
> >  Obtained from:	Wheel Systems Sp. z o.o. http://www.wheelsystems.com
> >
> >Modified:
> >  head/sbin/hastd/primary.c
> >
> Note that if you are sigwaiting signals, these signals should be masked,
> otherwise, there is a race condition. I have not read the code, maybe
> this is not a problem.

I do that, yes.

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!

--RNRUMt0ZF5Yaq/Aq
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)

iEYEARECAAYFAkx8oBMACgkQForvXbEpPzS1/gCg6dqLqInRQu1WkpwQ3K2Isldl
uroAmgKX5gTmUKhsE09g6kjSihSOZwxg
=8k36
-----END PGP SIGNATURE-----

--RNRUMt0ZF5Yaq/Aq--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100831062419.GK1871>