Date: Thu, 24 Jan 2013 17:35:33 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Michael Gmelin <freebsd@grem.de> Cc: freebsd-ports@freebsd.org Subject: Re: Using bidirectional authentication in pkgng Message-ID: <868v7itu7e.fsf@ds4.des.no> In-Reply-To: <20130124170014.57c5fa1a@bsd64.grem.de> (Michael Gmelin's message of "Thu, 24 Jan 2013 17:00:14 %2B0100") References: <20130118035721.283135fb@bsd64.grem.de> <50F9B6CC.3040303@infracaninophile.co.uk> <20130122193035.4c51be04@bsd64.grem.de> <20130123004147.GG27275@ithaqua.etoilebsd.net> <86d2wuvrjg.fsf@ds4.des.no> <20130124121942.07436be3@bsd64.grem.de> <86r4lau2wh.fsf@ds4.des.no> <20130124151629.588c33c8@bsd64.grem.de> <86libitxit.fsf@ds4.des.no> <20130124170014.57c5fa1a@bsd64.grem.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Michael Gmelin <freebsd@grem.de> writes: > Dag-Erling Sm=C3=B8rgrav <des@des.no> writes: > > Some of the code in http.c is so deeply nested that it is almost > > impossible to stay within 80 characters. This is a clear sign that > > the code needs to be rewritten. > Ok, is that only for libfetch or for all of kernel (just for future > reference). Not sure what you mean; libfetch is not part of the kernel, and deep nesting is almost always a symptom of poor structure or insufficient modularization. > Thanks for the detailed explanation. So do you think you could fix > these style issues yourself, or should I give it a shot (I'm certain I > will miss *some* of those issues but it will definitely get better). I could fix your mistakes, but then you wouldn't learn from them :) Contact me off-list when you have a new patch. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?868v7itu7e.fsf>