Date: Thu, 1 May 2008 17:28:50 -0400 From: John Baldwin <jhb@freebsd.org> To: Rui Paulo <rpaulo@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/i386/cpufreq est.c Message-ID: <200805011728.51152.jhb@freebsd.org> In-Reply-To: <481A3406.8080007@FreeBSD.org> References: <200802281910.m1SJAgm1083976@repoman.freebsd.org> <200805011547.07007.jhb@freebsd.org> <481A3406.8080007@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 01 May 2008 05:20:06 pm Rui Paulo wrote: > John Baldwin wrote: > > On Thursday 28 February 2008 02:10:42 pm Rui Paulo wrote: > >> rpaulo 2008-02-28 19:10:42 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/i386/cpufreq est.c > >> Log: > >> Validate the id16 values gathered from ACPI (previously a TODO item). > >> Style changes by me and njl. > > > > What is the purpose of the 'saved_id16' variable? It is never used. I think > > what might be better is to just read it once at the start of the loop and > > then restore it at the end of the loop, though phk@ has overwritten this with > > the "chew up all battery on laptops at all cost" patch. :-P > > > > What do you mean by 'It is never used.' ? > > % cat -n est.c | grep saved_id16 > 1082 uint16_t saved_id16; > 1111 est_get_id16(&saved_id16); Right, it is initialized, but it's value isn't actually _used_ anywhere. There isn't a est_set_id16(&saved_id16), etc. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200805011728.51152.jhb>