Date: Sun, 25 Feb 2001 23:38:04 -0600 From: Steve Price <steve@havk.org> To: Mike Meyer <mwm@mired.org> Cc: freebsd-ports@FreeBSD.org Subject: Re: ports/24450: [PATCH] "make udpate" in /usr/ports launches a GUI Message-ID: <20010225233804.N426@bsd.havk.org> In-Reply-To: <15001.59331.181219.295557@guru.mired.org>; from mwm@mired.org on Sun, Feb 25, 2001 at 11:21:07PM -0600 References: <200102260244.f1Q2iwu64619@freefall.freebsd.org> <15001.59331.181219.295557@guru.mired.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Feb 25, 2001 at 11:21:07PM -0600, Mike Meyer wrote: > steve@FreeBSD.org types: > > Synopsis: [PATCH] "make udpate" in /usr/ports launches a GUI > > > > State-Changed-From-To: open->closed > > State-Changed-By: steve > > State-Changed-When: Sun Feb 25 18:43:27 PST 2001 > > State-Changed-Why: > > Uncommenting SUP_FLAGS in /etc/defaults/make.conf or adding SUP_FLAGS > > to /etc/make.conf will have the same effect. > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=24450 > > Did you read the PR before closing it? The problem isn't just what's > in the subject line; the problem is the violation of POLA that comes > from the two makefiles having different default sup flags. Yes. I did read the PR before I closed it as I've done the many, many, many thousands of others that I've handled in the last six or so years as a committer. I think it is completely bogus to have it in either Makefile to be honest with you. If you want to supply a value for SUPFLAGS it should either be picked up from /etc/defaults/make.conf or /etc/make.conf. IMHO it violated POLA to have it in /usr/src/Makefile.inc1 in the first place. Where do you supply the value for SUPFILE, SUPHOST, PORTSSUPFILE, ...? I don't see any of those in Makefile.inc1 and by the same token I think it is bunk to have SUPFLAGS in there. But hey, I've could be wrong just as I've been wrong before. If others speak up and believe I'm full of sh*t, I'll be happy to commit your patch and move on. -Steve To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010225233804.N426>