Date: Sun, 2 Sep 2007 06:13:10 +0300 From: Giorgos Keramidas <keramida@FreeBSD.org> To: freebsd-www@FreeBSD.org Subject: tiny toplevel www/Makefile nit Message-ID: <20070902031310.GA1824@kobe.laptop>
next in thread | raw e-mail | index | archive | help
--PEIAKu/WMn1b1Hv9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Our toplevel www/Makefile includes both the standard <bsd.obj.mk> and the <bsd.subdir.mk> makefile includes, but seems a bit wrong. Tracing the .include directives in the files under /usr/share/mk I see that <bsd.obj.mk> already includes <bsd.subdir.mk> and this results in the following warnings: Script started on Sun Sep 2 06:04:24 2007 keramida@kobe:/home/keramida/hg/www/gker$ make WEB_ONLY=3Dyes ENGLISH_ONLY= =3Dyes WITHOUT_DOC=3Dyes "/usr/share/mk/bsd.subdir.mk", line 57: warning: duplicate script for targe= t "_SUBDIR" ignored "/usr/share/mk/bsd.subdir.mk", line 66: warning: duplicate script for targe= t "en" ignored "/usr/share/mk/bsd.subdir.mk", line 84: warning: duplicate script for targe= t "files" ignored "/usr/share/mk/bsd.subdir.mk", line 84: warning: duplicate script for targe= t "includes" ignored =3D=3D=3D> en (all) install /home/keramida/hg/www/gker/en/../share/sgml/catalog-cwd.xml /home/k= eramida/hg/www/gker/en/catalog-cwd.xml echo '<!ENTITY base "">' > /home/keramida/hg/www/gker/en/autogen.ent [...] Simply removing <bsd.subdir.mk> from our toplevel www/Makefile appears to have fixed this for me: %%% diff -r cea5df156013 Makefile --- a/Makefile Fri Aug 31 03:15:57 2007 +0000 +++ b/Makefile Sun Sep 02 06:09:15 2007 +0300 @@ -7,4 +7,3 @@ links: links: =20 .include <bsd.obj.mk> -.include <bsd.subdir.mk> %%% Does anyone know why we are pulling in <bsd.subdir.mk> twice? If there isn't a good reason to keep both includes, I'd like to remove <bsd.subdir.mk> to fix the warnings. - Giorgos --PEIAKu/WMn1b1Hv9 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFG2ipG1g+UGjGGA7YRAlvuAKCBDVvc6varfSCnF1tUCEhE3NQ5WgCeJIkI NFQ5DWoawRpss5KrCElct50= =C07U -----END PGP SIGNATURE----- --PEIAKu/WMn1b1Hv9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070902031310.GA1824>