Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 13 May 2013 10:14:06 -0600
From:      Will Andrews <will@firepipe.net>
To:        John Baldwin <jhb@freebsd.org>
Cc:        Marcel Moolenaar <marcel@freebsd.org>, svn-src-all@freebsd.org, Marcel Moolenaar <marcel@xcllnt.net>, attilio@freebsd.org, src-committers@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r250411 - in head/sys: conf kern sys
Message-ID:  <CADBaqmjxss1j-a5HfMJHU5mjt4AsO%2BpzYMJJY=7Ps=1JxrWuVQ@mail.gmail.com>
In-Reply-To: <201305122149.13566.jhb@freebsd.org>
References:  <201305091628.r49GSI33039873@svn.freebsd.org> <201305101533.26992.jhb@freebsd.org> <CAJ-FndBHD4sLquFcSYERkD2Mfo4iAbjBBuvtdOmp0PrqJE2MrA@mail.gmail.com> <201305122149.13566.jhb@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, May 12, 2013 at 7:49 PM, John Baldwin <jhb@freebsd.org> wrote:

> Also, while LK_NOWITESS works fine for lockmgr's API (it already takes a
> flag
> argument), having that sort of thing in our other lock APIs is messier
> (they
> generally do not have flags).  This is why a per-thread flag seemed
> simpler to
> me for this as you don't have to change umpteen locking APIs to add a new
> flags field.
>

Another problem is that approach is far too blunt; in most cases false
positive LORs are specific to a particular pair of instances of locks.
 You'd probably still want to receive witness notifications for other LORs.

--Will.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADBaqmjxss1j-a5HfMJHU5mjt4AsO%2BpzYMJJY=7Ps=1JxrWuVQ>