Date: Thu, 22 May 2008 11:19:14 -0600 From: Scott Long <scottl@samsco.org> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: cvs-src@FreeBSD.org, Sam Leffler <sam@FreeBSD.org>, Ed Schouten <ed@FreeBSD.org>, cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/share/man/man3 Makefile queue.3 src/sys/sys queue.h Message-ID: <4835AB12.9060306@samsco.org> In-Reply-To: <4835AA65.6070708@FreeBSD.org> References: <200805221440.m4MEe32W039559@repoman.freebsd.org> <4835A619.3010502@FreeBSD.org> <4835A71E.3030703@freebsd.org> <4835AA65.6070708@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Maxim Sobolev wrote: > Sam Leffler wrote: >> Maxim Sobolev wrote: >>> Ed Schouten wrote: >>>> The OpenBSD version of SLIST_REMOVE_NEXT() needs a reference to >>>> the list >>>> head, even though it is unused. >>> >>> I don't think it's necessary. sys/queue.h API is not supposed to be >>> portable across different operating systems. The need to pass list >>> head around may impede macro usefulness. >> Gratuitous differences impede porting. If it's not a big deal then >> maintain compatibility. We already have stupid differences in various >> areas that must be papered over when code is brokered between systems. > > This is local use convenience vs. easy of porting tradeoff. On one hand > API is used heavily in the kernel on the other I don't think we have lot > of kernel code being ported from OpenBSD nowadays. That's pretty presumptuous to say, and untrue. > So that local use > convinience should win a big. It'll be more convenient to follow what Ed is comfortable with and what he's already done than to nit pick such a minor detail =-) Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4835AB12.9060306>