Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 25 Apr 2014 11:13:27 +0200
From:      Tijl Coosemans <tijl@FreeBSD.org>
To:        Baptiste Daroussin <bapt@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r352093 - head/x11/startup-notification
Message-ID:  <20140425111327.3e351b84@kalimero.tijl.coosemans.org>
In-Reply-To: <201404250738.s3P7c2CV097634@svn.freebsd.org>
References:  <201404250738.s3P7c2CV097634@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 25 Apr 2014 07:38:02 +0000 (UTC) Baptiste Daroussin wrote:
> Author: bapt
> Date: Fri Apr 25 07:38:01 2014
> New Revision: 352093
> URL: http://svnweb.freebsd.org/changeset/ports/352093
> QAT: https://qat.redports.org/buildarchive/r352093/
> 
> Log:
>   Switch to USES=libtool
>   Strip binaries
> 
> Modified:
>   head/x11/startup-notification/Makefile
>   head/x11/startup-notification/pkg-plist
> 
> Modified: head/x11/startup-notification/Makefile
> ==============================================================================
> --- head/x11/startup-notification/Makefile	Fri Apr 25 07:34:14 2014	(r352092)
> +++ head/x11/startup-notification/Makefile	Fri Apr 25 07:38:01 2014	(r352093)
> @@ -4,7 +4,7 @@
>  
>  PORTNAME=	startup-notification
>  PORTVERSION=	0.12
> -PORTREVISION=	1
> +PORTREVISION=	2
>  CATEGORIES=	x11 gnome
>  MASTER_SITES=	http://www.freedesktop.org/software/startup-notification/releases/
>  DIST_SUBDIR=	gnome2
> @@ -12,16 +12,15 @@ DIST_SUBDIR=	gnome2
>  MAINTAINER=	gnome@FreeBSD.org
>  COMMENT=	Library that supports startup notification spec from freedesktop.org
>  
> -LIB_DEPENDS=	xcb-util:${PORTSDIR}/x11/xcb-util
> +LIB_DEPENDS=	libxcb-util.so:${PORTSDIR}/x11/xcb-util
>  
>  USE_XORG=	x11
> -USE_AUTOTOOLS=	libtool
> -USES=		gmake pathfix pkgconfig
> -USE_GNOME=	ltasneededhack
> +USES=		gmake libtool pathfix pkgconfig
>  GNU_CONFIGURE=	yes
>  USE_LDCONFIG=	yes
>  CPPFLAGS+=	-I${LOCALBASE}/include
>  LDFLAGS+=	-L${LOCALBASE}/lib
>  CONFIGURE_ARGS+=ac_cv_lib_ICE_IceConnectionNumber=no
> +INSTALL_TARGET=	install-strip
>  
>  .include <bsd.port.mk>
> 
> Modified: head/x11/startup-notification/pkg-plist
> ==============================================================================
> --- head/x11/startup-notification/pkg-plist	Fri Apr 25 07:34:14 2014	(r352092)
> +++ head/x11/startup-notification/pkg-plist	Fri Apr 25 07:38:01 2014	(r352093)
> @@ -5,9 +5,9 @@ include/startup-notification-1.0/libsn/s
>  include/startup-notification-1.0/libsn/sn-util.h
>  include/startup-notification-1.0/libsn/sn.h
>  lib/libstartup-notification-1.a
> -lib/libstartup-notification-1.la
>  lib/libstartup-notification-1.so
>  lib/libstartup-notification-1.so.0
> +lib/libstartup-notification-1.so.0.0.0
>  libdata/pkgconfig/libstartup-notification-1.0.pc
>  @dirrm include/startup-notification-1.0/libsn
>  @dirrm include/startup-notification-1.0

It's probably better to use libtool:keepla here.  There are too many
ports that depend on this port with .la files that may refer to
libstartup-notification-1.la.

I've been thinking if it would be possible for pkg to register .la files
(and their references to other libraries) like it does with .so files.
Then you could find out if there are references lurking in other ports
with pkg rquery.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140425111327.3e351b84>