Date: Tue, 4 May 2004 20:30:37 -0700 From: "David O'Brien" <obrien@freebsd.org> To: Tim Kientzle <kientzle@freebsd.org>, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, Andrew.Li@alcatel.com.au Subject: Re: cvs commit: src/usr.bin/tar fts.c fts.h Message-ID: <20040505033037.GA74624@dragon.nuxi.com> In-Reply-To: <20040504232632.GA69416@gsmx07.alcatel.com.au> References: <200405041721.i44HL22l029797@repoman.freebsd.org> <20040504232632.GA69416@gsmx07.alcatel.com.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, May 05, 2004 at 09:26:32AM +1000, Peter Jeremy wrote: > On 2004-May-04 10:21:02 -0700, Tim Kientzle <kientzle@freebsd.org> wrote: > >kientzle 2004/05/04 10:21:02 PDT > > Added files: > > usr.bin/tar fts.c fts.h > > Log: > > Include local copies of fts.c and fts.h to be used ONLY on non-FreeBSD > > systems. The fts.h here is an exact copy of include/fts.h (except for > > an initial explanatory comment and the revision tags, of course). The > > fts.c here is slightly modified from lib/libc/gen/fts.c so it can > > compile correctly on non-FreeBSD systems. ... > be usable on anything other than Linux systems due to the '#ifdef LINUX' > near the top - if this was '#ifndef __FreeBSD__', the portability would > be enhanced. Also why spell it "#ifdef LINUX" vs. what all compilers already define for you -- "#ifdef linux" (or "#ifdef __gnu_linux__")? -- -- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040505033037.GA74624>