Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 26 Feb 2001 08:48:46 +0200
From:      Maxim Sobolev <sobomax@FreeBSD.org>
To:        Garrett Rooney <rooneg@electricjellyfish.net>
Cc:        ports@FreeBSD.org, jhk@FreeBSD.org, gad@FreeBSD.org, reg@FreeBSD.org
Subject:   Re: [patch] which package functionality for pkg_info
Message-ID:  <3A99FC4E.B825CB6B@FreeBSD.org>
References:  <20010225161633.C94657@electricjellyfish.net> <200102252125.f1PLPH132145@vic.sabbo.net> <20010225192632.C37487@electricjellyfish.net> <20010225200351.A48200@electricjellyfish.net>

next in thread | previous in thread | raw e-mail | index | archive | help
Garrett Rooney wrote:

> amazing how you find stupid bugs the minute you send off the email with the
> patch in it ;-)
>
> this version actually produces the correct output when there are files in the
> plist that have the same beginning as the target, but a different end.

Looks better now, however there are several placed when something like the following
is used:
len1 = strlen(str1);
len2 = strlen(str2);
tmp = calloc(len1 + len2 + 2, sizeof(char));
if (tmp == NULL)
    bah!();
sprintf(tmp, "%s/%s", str1, str2);

Please replace the whole mess with:
asprintf(&tmp, "%s/%s", str1, str2);
if (tmp == NULL)
    bah!();

-Maxim


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3A99FC4E.B825CB6B>