Date: Tue, 3 Jun 2014 18:10:20 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Adrian Chadd <adrian@freebsd.org> Cc: Marcel Moolenaar <marcel@freebsd.org>, Ian Lepore <ian@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Marcel Moolenaar <marcel@xcllnt.net>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r266974 - in head/sys: dev/dc dev/fxp dev/mii dev/netmap kern net Message-ID: <20140603141020.GB50679@FreeBSD.org> In-Reply-To: <20140603085941.GW50679@FreeBSD.org> References: <201406021754.s52Hsd1B039620@svn.freebsd.org> <CAJ-VmonRqXrzrqQys_9s7-o8DFmOE_c_BZWupezm0i%2BW7E09vA@mail.gmail.com> <CAJ-VmonDJCLYWBPiz1ntFRm8aj4WQd5iHMKK0Wm3hcdjZmxghw@mail.gmail.com> <DA4CB2BA-A551-47A4-9E44-766FA29E2EF2@xcllnt.net> <1401735801.20883.103.camel@revolution.hippie.lan> <CAJ-VmomJyYh2XDBO4JRghRzRzL9yRVZScGDyG44TNytSjXBYFg@mail.gmail.com> <20140603085941.GW50679@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 03, 2014 at 12:59:41PM +0400, Gleb Smirnoff wrote: T> On Mon, Jun 02, 2014 at 12:27:47PM -0700, Adrian Chadd wrote: T> A> >> > .. and actually, bikeshedding for a moment, would we be able to move a T> A> >> > lot of these accessor methods over to inlines? Would that break the T> A> >> > Juniper way of doing things? T> A> >> T> A> >> That would definitely break Juniper as it doesn't give a stable T> A> >> ABI. T> A> >> T> A> >> I've suggested an approach that allows for both, but it was deemed T> A> >> unnecessary. The argument being that the function call overhead is T> A> >> negligible. T> A> >> T> A> >> We can always revisit that decision if needed... T> A> >> T> A> > T> A> > In my experience, function call overhead is anything but minimal, T> A> > especially on ARM platforms. T> A> T> A> Same on MIPS. T> T> And same on amd64. While benchmarking the counter(9), I even encountered T> artifacts when function call was faster than inline. T> T> Of course, function call shouldn't be via a pointer. Sorry, I misunderstood the "anything but minimal" phrase. That's why my reply Adrian and Ian looks odd. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140603141020.GB50679>