Date: Wed, 04 Jun 2014 09:10:03 +0300 From: Alexander Motin <mav@FreeBSD.org> To: Bryan Drewery <bdrewery@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r267029 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <538EB83B.70700@FreeBSD.org> In-Reply-To: <538EA8E4.1070300@FreeBSD.org> References: <201406032106.s53L63oR085624@svn.freebsd.org> <538EA8E4.1070300@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04.06.2014 08:04, Bryan Drewery wrote: > On 6/3/2014 4:06 PM, Alexander Motin wrote: >> Author: mav >> Date: Tue Jun 3 21:06:03 2014 >> New Revision: 267029 >> URL: http://svnweb.freebsd.org/changeset/base/267029 >> >> Log: >> Replace gethrtime() with cpu_ticks(), as source of random for the taskqueue >> selection. gethrtime() in our port updated with HZ rate, so unusable for >> this specific purpose, completely draining benefit of multiple taskqueues. >> >> MFC after: 2 weeks >> >> Modified: >> head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c >> >> Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c >> ============================================================================== >> --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c Tue Jun 3 21:02:19 2014 (r267028) >> +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c Tue Jun 3 21:06:03 2014 (r267029) >> @@ -953,7 +953,7 @@ spa_taskq_dispatch_ent(spa_t *spa, zio_t >> if (tqs->stqs_count == 1) { >> tq = tqs->stqs_taskq[0]; >> } else { >> - tq = tqs->stqs_taskq[gethrtime() % tqs->stqs_count]; >> + tq = tqs->stqs_taskq[cpu_ticks() % tqs->stqs_count]; >> } >> >> taskq_dispatch_ent(tq, func, arg, flags, ent); >> > > FYI r267038. Thanks. I am sorry. -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?538EB83B.70700>