Date: Mon, 4 Mar 2013 23:15:08 +0000 (UTC) From: Jack F Vogel <jfv@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r247823 - head/sys/dev/ixgbe Message-ID: <201303042315.r24NF8rG030772@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: jfv Date: Mon Mar 4 23:15:07 2013 New Revision: 247823 URL: http://svnweb.freebsd.org/changeset/base/247823 Log: Fix a small, but important bug, a task drain was mistakenly being compiled only when setting LEGACY_TX, this means you would not get the drain when needed on detach!! Thanks to Bryan Venteicher (bryanv@freebsd.org) for catching this little gremlin!! :) Modified: head/sys/dev/ixgbe/ixgbe.c Modified: head/sys/dev/ixgbe/ixgbe.c ============================================================================== --- head/sys/dev/ixgbe/ixgbe.c Mon Mar 4 23:07:40 2013 (r247822) +++ head/sys/dev/ixgbe/ixgbe.c Mon Mar 4 23:15:07 2013 (r247823) @@ -654,7 +654,7 @@ ixgbe_detach(device_t dev) for (int i = 0; i < adapter->num_queues; i++, que++, txr++) { if (que->tq) { -#ifdef IXGBE_LEGACY_TX +#ifndef IXGBE_LEGACY_TX taskqueue_drain(que->tq, &txr->txq_task); #endif taskqueue_drain(que->tq, &que->que_task);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201303042315.r24NF8rG030772>