Date: Tue, 7 May 2002 00:56:46 +0200 (CEST) From: Piet Honkoop <piet@wirehub.net> To: dwmalone@FreeBSD.org Cc: piet.honkoop@softcontrol.nl, <bp@FreeBSD.org>, <freebsd-bugs@FreeBSD.org> Subject: Re: misc/37775: netsmb/smb_subr.c needs opt_global.h in SMP environment Message-ID: <20020507004558.Q58556-100000@mefisto.wirehub.nl> In-Reply-To: <200205061825.g46IPpr98549@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 6 May 2002 dwmalone@FreeBSD.org wrote:
> Synopsis: netsmb/smb_subr.c needs opt_global.h in SMP environment
>
> State-Changed-From-To: open->feedback
> State-Changed-By: dwmalone
> State-Changed-When: Mon May 6 11:23:05 PDT 2002
> State-Changed-Why:
> Boris suggests that this is a more general problem and that the
> best thing to do is compile smbfs into the kernel. (See the
> PR audit trail for his full message).
>
Can imagine that because compiling into the kernel does produce a working
situation. Looking further into the situation, the logic seems to be that
the kernel compilation process uses (together with a hurdle of other
options): -D_KERNEL -include opt_global.h
whereas modules only use: -D_KERNEL
which would explain why opt_global.h is not included in the module.
Does this mean there is an omission in kmod.mk? (grep -r through /usr/sys
does bring you somewhere...)
line 92:
CFLAGS+= ${COPTS} -D_KERNEL ${CWARNFLAGS}
should be changed into
CFLAGS+= ${COPTS} -D_KERNEL -include opt_global.h ${CWARNFLAGS}
then.
Correct?
Ciao,
Piet
>
> Responsible-Changed-From-To: bp->freebsd-bugs
> Responsible-Changed-By: dwmalone
> Responsible-Changed-When: Mon May 6 11:23:05 PDT 2002
> Responsible-Changed-Why:
> Boris suggests that this is a more general problem and that the
> best thing to do is compile smbfs into the kernel. (See the
> PR audit trail for his full message).
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=37775
>
--
=========================================================================
Wirehub! Internet BV tel. +31 10 2448344
Westzeedijk 487 fax. +31 10 2448356
3024 EL Rotterdam http://www.wirehub.net
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020507004558.Q58556-100000>