Date: Tue, 03 Feb 2009 20:00:51 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: antab@valka.is Cc: antab@FreeBSD.org, perforce@FreeBSD.org, gonzo@bluezbox.com, hselasky@c2i.net Subject: Re: PERFORCE change 156978 for review Message-ID: <20090203.200051.-216598028.imp@bsdimp.com> In-Reply-To: <2757071E-6E55-43F5-B298-408AFC6793C6@valka.is> References: <49850FB9.9040008@bluezbox.com> <200902011247.10404.hselasky@c2i.net> <2757071E-6E55-43F5-B298-408AFC6793C6@valka.is>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <2757071E-6E55-43F5-B298-408AFC6793C6@valka.is>
Arnar Mar Sig <antab@valka.is> writes:
: On Feb 1, 2009, at 12:47 PM, Hans Petter Selasky wrote:
: > On Sunday 01 February 2009, Oleksandr Tymoshenko wrote:
: >> Arnar Mar Sig wrote:
: >>> http://perforce.freebsd.org/chv.cgi?CH=156978
: >>>
: >>> Change 156978 by antab@antab_farm on 2009/02/01 00:58:58
: >>>
: >>> AVR32 support. The kernel boots on NGW100 but there is still alot
: >>> of
: >>> work to be done. At the moment it crashes somewhere in uma_startup3.
: >>
: >> That's just cool! :) Thanks a lot for your hard work.
: >
: > Just a small style nit:
: >
: > Use \t or TAB after "#define" instead of space.
: Usually do, but some code is copied between terms and lost \t, coding
: style is also not according style(9) but that will be fixes.
:
: > Looking forward to programming USB support for the AVR32.
: Good, but i would like to get some clock framework in place before
: doing any device driver, I really dislike the hardcoded clock speeds
: that are used in in some at91 drivers.
I'd love to see this to. They are only 'hard coded' in at91 drivers
because of time pressures. Also, I'd move at91 devices to
dev/atmel...
warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090203.200051.-216598028.imp>