Date: Tue, 27 Feb 2007 09:41:15 -0800 From: Sam Leffler <sam@errno.com> To: =?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/ifconfig af_atalk.c af_inet.c af_inet6.c af_ipx.c af_link.c ifconfig.c ifconfig.h Message-ID: <45E46D3B.9040203@errno.com> In-Reply-To: <86fy8rms5j.fsf@dwp.des.no> References: <200702242355.l1ONtlSE066370@repoman.freebsd.org> <86mz2zwq93.fsf@dwp.des.no> <45E461B5.9000404@errno.com> <86fy8rms5j.fsf@dwp.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
Dag-Erling Smørgrav wrote: > Sam Leffler <sam@errno.com> writes: >> Dag-Erling Smørgrav wrote: >>> This commit breaks interface cloning. Apparently, the global variable >>> "name" is not initialized before ifclonecreate() is called, so the >>> SIOCIFCREATE2 ioctl() is called with an empty string instead of the >>> interface name. >> Hmm, worked for bridge for me. Can you provide the specific example? > > Is "ifconfig bridge0 create" specific enough? > > Insert a printf() in the right spot and you'll see name is empty when > ifclonecreate() is called. I'd (apparently) tested with a wrong binary. Unfortunately noone caught it in the public review either. Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?45E46D3B.9040203>