Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 5 Dec 2015 11:00:30 -0800
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r291864 - head/lib/libc/tests/ssp
Message-ID:  <5663344E.2050308@FreeBSD.org>
In-Reply-To: <201512051856.tB5IuMsg067499@repo.freebsd.org>
References:  <201512051856.tB5IuMsg067499@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 12/5/15 10:56 AM, Bryan Drewery wrote:
> Author: bdrewery
> Date: Sat Dec  5 18:56:21 2015
> New Revision: 291864
> URL: https://svnweb.freebsd.org/changeset/base/291864
> 
> Log:
>   Fix regression in r291738: This really wants -lssp.
>   
>   The normal LIBADD is ssp_nonshared.  This also had a DPADD on LIBSSP which
>   does not actually exist, it is blank.
>   
>   Sponsored by:	EMC / Isilon Storage Division
> 
> Modified:
>   head/lib/libc/tests/ssp/Makefile
> 
> Modified: head/lib/libc/tests/ssp/Makefile
> ==============================================================================
> --- head/lib/libc/tests/ssp/Makefile	Sat Dec  5 17:40:11 2015	(r291863)
> +++ head/lib/libc/tests/ssp/Makefile	Sat Dec  5 18:56:21 2015	(r291864)
> @@ -10,7 +10,7 @@ CFLAGS.h_raw+=	-fstack-protector-all -Ws
>  CFLAGS.h_raw+=	-fsanitize=bounds
>  .elif ${COMPILER_TYPE} == "gcc"
>  CFLAGS.h_raw+=	--param ssp-buffer-size=1
> -LIBADD+=	ssp
> +LDADD+=	-lssp
>  .endif
>  
>  NETBSD_ATF_TESTS_SH=	ssp_test
> 

This may actually need to be LIBADD+=ssp_nonshared. I am just too busy
at the moment to look into it properly.

-- 
Regards,
Bryan Drewery



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5663344E.2050308>