Date: Sun, 08 Jun 2014 16:18:41 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> Cc: Konstantin Belousov <kostikbel@gmail.com>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, Alfred Perlstein <bright@mu.org>, src-committers@freebsd.org Subject: Re: svn commit: r267233 - in head: . bin/rmail gnu/usr.bin/binutils/addr2line gnu/usr.bin/binutils/nm gnu/usr.bin/binutils/objcopy gnu/usr.bin/binutils/objdump gnu/usr.bin/binutils/readelf gnu/usr.bin/... Message-ID: <5394D331.80603@FreeBSD.org> In-Reply-To: <20140608184451.GZ3991@kib.kiev.ua> References: <201406081729.s58HTWkc006213@svn.freebsd.org> <74512A27-DD5F-4D43-BFA1-0AC04E0D08B4@FreeBSD.org> <20140608182728.GX3991@kib.kiev.ua> <5394ABD2.5040009@mu.org> <20140608184451.GZ3991@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --r25QU50au8l4hKtPvcHnGKfAlC4e81hKq Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 6/8/2014 1:44 PM, Konstantin Belousov wrote: > On Sun, Jun 08, 2014 at 11:30:42AM -0700, Alfred Perlstein wrote: >> On 6/8/14 11:27 AM, Konstantin Belousov wrote: >>> On Sun, Jun 08, 2014 at 05:38:49PM +0000, Bjoern A. Zeeb wrote: >>>> On 08 Jun 2014, at 17:29 , Bryan Drewery <bdrewery@FreeBSD.org> wrot= e: >>>> >>>>> Author: bdrewery >>>>> Date: Sun Jun 8 17:29:31 2014 >>>>> New Revision: 267233 >>>>> URL: http://svnweb.freebsd.org/changeset/base/267233 >>>>> >>>>> Log: >>>>> In preparation for ASLR [1] support add WITH_PIE to support build= ing with -fPIE. >>>>> >>>>> This is currently an opt-in build flag. Once ASLR support is read= y and stable >>>>> it should changed to opt-out and be enabled by default along with= ASLR. >>>>> >>>>> Each application Makefile uses opt-out to ensure that ASLR will b= e enabled by >>>>> default in new directories when the system is compiled with PIE/A= SLR. [2] >>>>> >>>>> Mark known build failures as NO_PIE for now. >>>> No, no, no, no more NOs! >>>> >>>> I?ll leave it to others who understand the current build system in d= ays when it?s not broken to fix this entire splattering across all these = Makefiles; we really need a better way for this. >>> I have no words to express my dissatisfaction with this commit. >>> If change to the build of _some_ usermode binaries require patching >>> of loader', csu and rtld Makefiles, obviously it is done wrong. >>> >>> Why almost half of the binaries require opt-out ? >>> >>> PLEASE REVERT THIS. >> Wait. Does this not serve as a useful stake in the ground for people = to=20 >> come in and update things? Instead of asking to back out, shouldn't w= e=20 >> be doing an announcement "ok folks, it's now time to fix this!" and mo= ve=20 >> forward? Otherwise we may never get any pie. >=20 > Let me reformulate. >=20 > Somebody commits broken change, despite it was pointed out by many > before the commit. From the changes it is obvious that people which > proposed it do not understand what they hack on. And then, somebody els= e > must run and 'fix' previously non-broken code. >=20 > Sure, you get the pie. >=20 Nothing here is broken by default. Nothing is broken with WITH_PIE enabled either. I will not revert this. It lays groundwork for ASLR support. No one has identified anything actually wrong with this commit. so@ made the call on making this OPT-OUT per Makefile. Not me or Shawn. The ASLR patches have been in public for review for 6 months or more now. You've all had opportunities to weigh in on them. I encourage more review on the ASLR patches themselves as well. The presentation at BSDCan was 100% positive by my account. Whether you think ASLR, or the implementation, is good or not doesn't matter much if you don't participate. We are the last OS to not have it and it does have benefits. --=20 Regards, Bryan Drewery --r25QU50au8l4hKtPvcHnGKfAlC4e81hKq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJTlNM2AAoJEDXXcbtuRpfPK0AH/jQngRW5r4RutgcGlmSmmjnB I2cuhwEnVDR5is3ife1N/Y0DVs0o9zi+s09CrcEVLKOLhzN6pOYSipCedzA8SSj6 4+ajePmXUfXENFZ136uy3TgGN8mMbBkHmR1lYLBQiOSCQw9qU2TX7GrILGbERX45 mVJUIYzw/89cU1l4cjI5ixU5Q8YbTlB+8B5nRQCrvjcLV2s5idXvtDGKDU2mecV4 GoASGwt1yzHOmnuoJe1RZGkYIjIC7Kf4n3XpSq3+weRRvgFNvNtczlwNtpXaiwpO hEryp4Tty+Prb7B9hYN+NTnBdiaEb0FEVLG4bX8Ls8cJT37LETAyqRLP0CgGAUo= =z4va -----END PGP SIGNATURE----- --r25QU50au8l4hKtPvcHnGKfAlC4e81hKq--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5394D331.80603>