Date: Fri, 26 Nov 2010 20:24:53 -0800 From: Jack Vogel <jfvogel@gmail.com> To: beezarliu <beezarliu@yahoo.com.cn> Cc: freebsd-net <freebsd-net@freebsd.org>, Ryan Stone <rysto32@gmail.com> Subject: Re: Re: 82599 receiving packets with vlan tag=0 (vlan strip problem)? Message-ID: <AANLkTikG8RJQw%2Bh1SHZPs1cHGrM%2B3LfniZrdLqVoPVtr@mail.gmail.com> In-Reply-To: <201011270946271408828@yahoo.com.cn> References: <201011261037105152721@yahoo.com.cn> <AANLkTikYZN0hoH6Ht-ZhukM2OVXZOyvU9-O%2BpbJ%2BsBj9@mail.gmail.com> <AANLkTimWVJhtu8LrZ_tn0Tdr-vs9PmPnW9SjebT7jnyM@mail.gmail.com> <AANLkTik%2B4Ag1HYXDWJvn2fTx6M%2Bpa9o29-A8j6qVRhZ_@mail.gmail.com> <AANLkTikwcRW%2BdqY=NTSbJsr3daEd-8usPo0Rw%2BhA_D-8@mail.gmail.com> <AANLkTin3%2BbCaXoPxTQsvzmqgtpA1zSY8f17Qh-nqymPw@mail.gmail.com> <201011270946271408828@yahoo.com.cn>
next in thread | previous in thread | raw e-mail | index | archive | help
Will you please test with the code I just checked in and see if it also eliminates the problem, if not I can change it to your method. Just for the record, I was not aware of a hardware bug, and for right now no one is around :) I will ask around next week to see if something was known that I missed. Thanks, Jack 2010/11/26 beezarliu <beezarliu@yahoo.com.cn> > On 2010-11-27 05:01:11, Ryan Stone wrote: > >On Fri, Nov 26, 2010 at 3:46 PM, Jack Vogel <jfvogel@gmail.com> wrote: > >> Ahh, OK, so how would this solution work: > >> > >> In rxeof, in addition to requiring VP to be set, also check that > >> adapter->num_vlans is non-zero, in order to store the tag. > >> > >> Jack > > > >Yes, I believe that will work. > > > >Ryan Stone > >_______________________________________________ > >freebsd-net@freebsd.org mailing list > >http://lists.freebsd.org/mailman/listinfo/freebsd-net > >To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > > From ixgbe_init -> ixgbe_init_lock -> ixgbe_setup_vlan_hw_support, > I'm sure the VME bit is set for all rx queues. > But in my testing, the vlan tag is not stripped but VP bit is set. > It's very strange, and I'm not sure it's hardware bug. > > I currently fix it by checking vlan tag is not zero before add M_VLANTAG, > because vlan tag id 0 is not used. > > if ((staterr & IXGBE_RXD_STAT_VP) && vtag)= { > sendmp->m_pkthdr.ether_vtag =3D vt= ag; > sendmp->m_flags |=3D M_VLANTAG; > } > > > Thanks > Beezar > > > __________________________________________________ > =B8=CF=BF=EC=D7=A2=B2=E1=D1=C5=BB=A2=B3=AC=B4=F3=C8=DD=C1=BF=C3=E2=B7=D1= =D3=CA=CF=E4? > http://cn.mail.yahoo.com >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTikG8RJQw%2Bh1SHZPs1cHGrM%2B3LfniZrdLqVoPVtr>