Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 23 Jul 2001 12:35:09 +0300
From:      Ruslan Ermilov <ru@FreeBSD.org>
To:        Mike Pritchard <mpp@mppsystems.com>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/share/examples/mdoc example.1 example.3 example.4
Message-ID:  <20010723123509.B79427@sunbay.com>
In-Reply-To: <20010722041441.B1683@mppsystems.com>; from mpp@mppsystems.com on Sun, Jul 22, 2001 at 04:14:41AM -0500
References:  <200107181004.f6IA4YU17817@freefall.freebsd.org> <20010722041441.B1683@mppsystems.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jul 22, 2001 at 04:14:41AM -0500, Mike Pritchard wrote:
> On Wed, Jul 18, 2001 at 03:04:34AM -0700, Ruslan Ermilov wrote:
> > ru          2001/07/18 03:04:34 PDT
> > 
> >   Modified files:
> >     share/examples/mdoc  example.1 example.3 example.4 
> >   Log:
> >   Removed the comment that required all FreeBSD manpages
> >   to have the $FreeBSD$ keyword, as this is now enforced
> >   by the CVSROOT/commit_prep.pl script.
> 
> I think there should still be a comment stating that the FreeBSD id should
> be present.  Remember, these examples are intended to be taken and
> edited by others to create new man pages.  Since most people do
> not regularly create new files and add them to the repository,
> keeping the comment about the FreeBSD id line (and show where it should
> be placed in the man page) will help them from having commit_prep
> complain at them when they finally do try and check their new man
> page in.
> 
The (already existing) $FreeBSD$ in these examples is self-documenting.
If people don't know that commit-prep.pl will complain about missing
$FreeBSD$ line, they are probably also not aware of the fact that
commit-prep.pl will only accept an uninitialized $FreeBSD$, so the
one from skeleton is bogus anyway.  :-)

And some of these gratuituous comments are erroneously imported when
a template is applied.

grep "Note: The date here should be updated" reveals these:

lib/libc/db/man/dbm.3
share/examples/mdoc/example.1
share/examples/mdoc/example.3
share/examples/mdoc/example.4
sys/boot/common/loader.8
sys/boot/i386/pxeldr/pxeboot.8


Cheers,
-- 
Ruslan Ermilov		Oracle Developer/DBA,
ru@sunbay.com		Sunbay Software AG,
ru@FreeBSD.org		FreeBSD committer,
+380.652.512.251	Simferopol, Ukraine

http://www.FreeBSD.org	The Power To Serve
http://www.oracle.com	Enabling The Information Age

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010723123509.B79427>