Date: Fri, 12 Nov 1999 23:09:59 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Peter Jeremy <peter.jeremy@alcatel.com.au> Cc: Mark Newton <newton@internode.com.au>, current@FreeBSD.ORG Subject: Re: panic: nexus_setup_intr: NULL irq resource! Message-ID: <Pine.BSF.4.10.9911122259130.17302-100000@alphplex.bde.org> In-Reply-To: <99Nov12.125653est.40350@border.alcanet.com.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 12 Nov 1999, Peter Jeremy wrote: > On 1999-Nov-12 12:35:01 +1100, Mark Newton wrote: > >The problem is that the BUS_SETUP_INTR() method for ISA seems to > >absolutely require the specification of an IRQ, even though IRQ > >specification is absolutely prohibited for non-master ports in > >AST-compatible multi-port sio cards. Gah. This is fixed differently (directly in the driver) in nsio (dev/sio/sio.c) rev.1.267. Both fixes are probably necessary and more or less correct. Drivers shouldn't attempt to register null interrupts, and attempting this probably shouldn't cause panics. > As an aside, why doesn't our SIO driver work with ports that don't > have interrupts? Same problem. Ports that don't have interrupts give polled mode, and the driver shouldn't attempt to register the null interrupts for polled mode, but this was broken when the driver was converted to new-bus. > >I'm not completely sure that this patch does the right thing > > Since your patch effectively turns isa_setup_intr() into a nop for > this case, a better patch would seem to be to skip the call to > BUS_SETUP_INTR() (and presumably bus_alloc_resource()) at the end > of sioattach() when you're attaching a slave SIO port. nsio still has the bus_alloc_resource(). This seems to be a harmless but bogus no-op if the resource isn't there. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.10.9911122259130.17302-100000>