Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 5 Jun 2012 08:56:32 -0700
From:      Greg Lewis <glewis@eyesbeyond.com>
To:        Jens Jahnke <jan0sch@gmx.net>
Cc:        scheidell@freebsd.org, bug-followup@freebsd.org, freebsd-ports-bugs@freebsd.org
Subject:   Re: ports/168559: Updated lang/clojure to version 1.4.0
Message-ID:  <20120605155632.GA9796@misty.eyesbeyond.com>
In-Reply-To: <20120604184821.65cdb089.jan0sch@gmx.net>
References:  <201206032153.q53LrFon077891@freefall.freebsd.org> <20120604184821.65cdb089.jan0sch@gmx.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 04, 2012 at 06:48:21PM +0200, Jens Jahnke wrote:
> Hi,
> 
> I reworked the patch according to the comments.
> 
> Regards,
> 
> Jens

Thanks Jens!  One final comment below:

> diff -ruN clojure.old/files/clojure-bin.in clojure/files/clojure-bin.in
> --- clojure.old/files/clojure-bin.in	2012-06-04 18:37:17.000000000 +0200
> +++ clojure/files/clojure-bin.in	2012-06-04 18:40:02.000000000 +0200
> @@ -2,4 +2,4 @@
>  #
>  # $FreeBSD: ports/lang/clojure/files/clojure-bin.in,v 1.8 2011/07/21 05:02:48 linimon Exp $
>  
> -JAVA_VERSION="%%JAVA_VERSION%%" "%%LOCALBASE%%/bin/java" -cp "%%JAVAJARDIR%%/jline.jar:%%JAVAJARDIR%%/clojure-1.2.0.jar:%%JAVAJARDIR%%/clojure-contrib-1.2.0.jar:%%JAVAJARDIR%%/swank-clojure-1.2.1.jar:$CLASSPATH" %%CLOJURE_JLINE_RUNNER%% clojure.main "$@"
> +JAVA_VERSION="%%JAVA_VERSION%%" "%%LOCALBASE%%/bin/java" -cp "%%JAVAJARDIR%%/jline.jar:%%JAVAJARDIR%%/clojure-${PORTVERSION}.jar:%%JAVAJARDIR%%/swank-clojure-1.4.2.jar:$CLASSPATH" %%CLOJURE_JLINE_RUNNER%% clojure.main "$@"

Here it should be %%PORTVERSION%% since ${PORTVERSION} won't be defined.
When the port is installed the ports infrastructure will take care of
expanding %%PORTVERSION%% to the correct value.

-- 
Greg Lewis                          Email   : glewis@eyesbeyond.com
Eyes Beyond                         Web     : http://www.eyesbeyond.com
Information Technology              FreeBSD : glewis@FreeBSD.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120605155632.GA9796>