Date: Wed, 9 May 2007 13:30:07 +0000 (UTC) From: Randall Stewart <rrs@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/netinet sctp_asconf.c sctp_auth.c sctp_indata.c sctp_input.c sctp_os_bsd.h sctp_output.c sctp_pcb.c sctp_pcb.h sctp_peeloff.c sctp_timer.c sctp_usrreq.c sctputil.c sctputil.h src/sys/netinet6 sctp6_usrreq.c Message-ID: <200705091330.l49DU77c069095@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
rrs 2007-05-09 13:30:07 UTC FreeBSD src repository Modified files: sys/netinet sctp_asconf.c sctp_auth.c sctp_indata.c sctp_input.c sctp_os_bsd.h sctp_output.c sctp_pcb.c sctp_pcb.h sctp_peeloff.c sctp_timer.c sctp_usrreq.c sctputil.c sctputil.h sys/netinet6 sctp6_usrreq.c Log: Two major items here: - All printf that was surrounded by #ifdef SCTP_DEBUG moves to a macro that does all of this. This removes all printfs from the code and makes the code more portable and easier to read. - Static Analysis (cisco) - found a few bugs, but mostly we add checks for NULL pointers and such to make the tool happy. We now pass the Cisco SA tools checks except for where it does not understand tailq/lists. We still need to look at the coverity tools output too (this is like the cisco SA tool) and see if it wants us to fix any other items. Hopefully this will be the last major churn in the code other than bug fixes. Revision Changes Path 1.13 +155 -333 src/sys/netinet/sctp_asconf.c 1.10 +49 -78 src/sys/netinet/sctp_auth.c 1.23 +77 -139 src/sys/netinet/sctp_indata.c 1.26 +236 -433 src/sys/netinet/sctp_input.c 1.17 +10 -2 src/sys/netinet/sctp_os_bsd.h 1.25 +214 -375 src/sys/netinet/sctp_output.c 1.28 +96 -163 src/sys/netinet/sctp_pcb.c 1.16 +4 -4 src/sys/netinet/sctp_pcb.h 1.9 +2 -11 src/sys/netinet/sctp_peeloff.c 1.15 +49 -76 src/sys/netinet/sctp_timer.c 1.26 +33 -33 src/sys/netinet/sctp_usrreq.c 1.30 +187 -138 src/sys/netinet/sctputil.c 1.19 +7 -7 src/sys/netinet/sctputil.h 1.21 +18 -24 src/sys/netinet6/sctp6_usrreq.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200705091330.l49DU77c069095>