Date: Thu, 17 Jul 2014 23:06:20 -0400 From: Adam Weinberger <adamw@adamw.org> To: John Marino <marino@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r362115 - head/archivers/liborange Message-ID: <335AC22C-BDF1-45C9-A073-26D93B4BB396@adamw.org> In-Reply-To: <201407162221.s6GMLul7047199@svn.freebsd.org> References: <201407162221.s6GMLul7047199@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_FC9B73DB-DB26-42DF-9DD1-8C403DE63B58 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 16 Jul, 2014, at 18:21, John Marino <marino@FreeBSD.org> wrote: > Author: marino > Date: Wed Jul 16 22:21:55 2014 > New Revision: 362115 > URL: http://svnweb.freebsd.org/changeset/ports/362115 > QAT: https://qat.redports.org/buildarchive/r362115/ > > Log: > archivers/liborange: Unbreak port by working around configure flaw > > The configure error "Not configured with libgsf or libole2 but that's > needed for MSI support" is caused by using the wrong configure option > of MSI that was introduced in last commit. > > Changing to MSI_CONFIGURE_ENABLE=libgsf to MSI_CONFIGURE_WITH=libgsf > should have solved the problem, but unfortunately there is a logic > flaw in the configure script. If --without-libgsf is passed to it, > it mistakenly tries to find it anyway with pkgconfig and then fails. > > The way to fix this properly is to patch the configure script, but I am > going to cheat by making libgsf an unconditional requirement as it was > before adamw fixed the options reversal. The attached patch might fix it? Just need to add USE_AUTOTOOLS=autoconf. # Adam --Apple-Mail=_FC9B73DB-DB26-42DF-9DD1-8C403DE63B58 Content-Disposition: attachment; filename=patch-configure.ac Content-Type: application/octet-stream; name="patch-configure.ac" Content-Transfer-Encoding: 7bit --- configure.ac.orig 2014-07-17 23:01:25.000000000 -0400 +++ configure.ac 2014-07-17 23:02:46.000000000 -0400 @@ -165,8 +165,8 @@ PKG_CHECK_MODULES([LIBGSF], [libgsf-1],, [AC_MSG_ERROR([Can't find libgsf-1])] ) + AC_DEFINE_UNQUOTED(WITH_LIBGSF, $my_with_libgsf, [Set to 1 when compiled with libgsf]) fi -AC_DEFINE_UNQUOTED(WITH_LIBGSF, $my_with_libgsf, [Set to 1 when compiled with libgsf]) dnl Conditional compile of MSI support (because it requires libole2) my_enable_msi=0 --Apple-Mail=_FC9B73DB-DB26-42DF-9DD1-8C403DE63B58 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii -- Adam Weinberger adamw@adamw.org http://www.adamw.org --Apple-Mail=_FC9B73DB-DB26-42DF-9DD1-8C403DE63B58--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?335AC22C-BDF1-45C9-A073-26D93B4BB396>