Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 17 Jun 2014 09:33:23 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r267575 - head/sys/x86/x86
Message-ID:  <201406170933.s5H9XNGG072271@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kib
Date: Tue Jun 17 09:33:22 2014
New Revision: 267575
URL: http://svnweb.freebsd.org/changeset/base/267575

Log:
  Do not reference native_lapic_ipi_*() functions in the UP build.
  The functions' definitions are protected by #ifdef SMP.
  Keeping apic_ops.ipi_*() methods NULL would allow to catch the use
  on UP machines.
  
  Reviewed by:	royger
  Sponsored by:	The FreeBSD Foundation

Modified:
  head/sys/x86/x86/local_apic.c

Modified: head/sys/x86/x86/local_apic.c
==============================================================================
--- head/sys/x86/x86/local_apic.c	Tue Jun 17 09:02:10 2014	(r267574)
+++ head/sys/x86/x86/local_apic.c	Tue Jun 17 09:33:22 2014	(r267575)
@@ -230,9 +230,11 @@ struct apic_ops apic_ops = {
 	.disable_pmc		= native_lapic_disable_pmc,
 	.reenable_pmc		= native_lapic_reenable_pmc,
 	.enable_cmc		= native_lapic_enable_cmc,
+#ifdef SMP
 	.ipi_raw		= native_lapic_ipi_raw,
 	.ipi_vectored		= native_lapic_ipi_vectored,
 	.ipi_wait		= native_lapic_ipi_wait,
+#endif
 	.set_lvt_mask		= native_lapic_set_lvt_mask,
 	.set_lvt_mode		= native_lapic_set_lvt_mode,
 	.set_lvt_polarity	= native_lapic_set_lvt_polarity,



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201406170933.s5H9XNGG072271>