Date: Wed, 16 May 2007 12:40:02 +0200 From: Alexander Leidinger <Alexander@Leidinger.net> To: Dag-Erling Smorgrav <des@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile Makefile.inc1 Message-ID: <20070516124002.6g6ox6y28048ws4g@webmail.leidinger.net> In-Reply-To: <200705160846.l4G8kaYr074481@repoman.freebsd.org> References: <200705160846.l4G8kaYr074481@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Quoting Dag-Erling Smorgrav <des@FreeBSD.org> (from Wed, 16 May 2007 =20
08:46:36 +0000 (UTC)):
> des 2007-05-16 08:46:36 UTC
>
> FreeBSD src repository
>
> Modified files:
> . Makefile Makefile.inc1
> Log:
> Expose all of {check,delete}-old{,-dirs,-files,-libs}.
The delete-old target only removes static libs. Yes, they are libs, =20
but they are not used in a life system, they are only used while =20
developing. That's the reason why I didn't add "libraries" to the =20
description of the delete-old target. The delete-old-libs target =20
exists to remove shared libs, which you should not do unconditionally =20
on a system (make sure no ports uses them anymore).
For the check-old target there's no reason to split up the targets, as =20
you can list them unconditionally. For developing convenience I did =20
chose to have the check-old-XXX targets in Makefile.inc1 ("make -f =20
Makefile.inc1 TARGET" works just fine). I see no need to expose all =20
targets.
So please revert this or do a forced commit to provide a good reason =20
why they need to be exposed.
As your recent commits to the delete-old/check-old part created a lot =20
of mails and follow up commits because of them, I suggest to discuss =20
further changes to the targets before committing the changes.
Bye,
Alexander.
--=20
Any clod can have the facts, but having opinions is an art.
=09=09-- Charles McCabe
http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7
http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070516124002.6g6ox6y28048ws4g>