Date: Sat, 30 Sep 2000 02:08:12 +0900 From: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org> To: takawata@shidahara1.planet.sci.kobe-u.ac.jp Cc: iwasaki@jp.freebsd.org, msmith@freebsd.org, acpi-jp@jp.freebsd.org, current@freebsd.org Subject: Re: ACPI megapatch Message-ID: <20000930020812S.iwasaki@jp.FreeBSD.org> In-Reply-To: <200009291538.AAA20648@libr.scitec.kobe-u.ac.jp> References: <20000930000450D.iwasaki@jp.FreeBSD.org> <200009291538.AAA20648@libr.scitec.kobe-u.ac.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
> >Here is a patch for your megapatch at > >http://people.FreeBSD.org/~iwasaki/acpi/patch-for-megapatch.diff > >I'll be happy if you accept and commit this :-) > > > > I think it is better bus attachment code is in MD part than in MI part. > And MD bus attachment code calls MI bus attachment code. > > For example,Current acpi_probe code rename to acpi_probesubr and > call it from acpi_probe in acpi_machdep.c . Hmm, I think you're talking about BI/BD. Most of ACPI code must be shared between IA32/IA64 (even bus interface code). Difference between them is very limited, we can put them in acpi_machdep.c. I like this model. NetBSD's pci code take this one (dev/pci/pci.c has MI code like pcimattach(), arch/*/pci/pci_machdep.c have a set of MD sub-routines for the specific machine architecture such as pci_conf_read().). I'm not sure this is correct or not, but it seems reasonable for me. > And probe method and identify method should not be confused. > Memory area check etc.... can be in MD acpi probe code. Yes, I think it's in acpi_machdep.c :-) if not, which one? Thanks To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000930020812S.iwasaki>