Date: Tue, 6 Apr 2004 20:10:25 -0700 (PDT) From: Stephan Uphoff <ups@tree.com> To: freebsd-gnats-submit@FreeBSD.org Subject: kern/65278: [patch] sio: kgdb debugger port initialization destroys default serial console speed Message-ID: <200404070310.i373APrI010753@www.freebsd.org> Resent-Message-ID: <200404070320.i373KJw7023230@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 65278
>Category: kern
>Synopsis: [patch] sio: kgdb debugger port initialization destroys default serial console speed
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Apr 06 20:20:19 PDT 2004
>Closed-Date:
>Last-Modified:
>Originator: Stephan Uphoff
>Release: current
>Organization:
>Environment:
N/A
>Description:
kgdb debugger port initialization in sio.c destroys default
serial console baud rate (comdefaultrate) if booted using a
serial console ( boothowto & RB_SERIAL).
>How-To-Repeat:
Use sio0 as console and sio1 as kgdb port.
Boot using the serial console.
After boot-up comdefaultrate will contain an arbitrary value based on
the state of the divisor of the gdb remote port.
>Fix:
Restrict comdefaultrate changes to console ports.
==== //depot/tree/orca/src/sys/dev/sio/sio.c#2 - /usr/develop/tree/orca/src/sys/dev/sio/sio.c ====
@@ -2945,7 +2945,7 @@
continue;
iobase = port;
s = spltty();
- if (boothowto & RB_SERIAL) {
+ if ((boothowto & RB_SERIAL) && COM_CONSOLE(flags)) {
boot_speed =
siocngetspeed(iobase, comdefaultrclk);
if (boot_speed)
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200404070310.i373APrI010753>