Date: Sun, 17 Mar 2013 13:33:39 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Andre Oppermann <andre@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r248417 - head/sys/sys Message-ID: <20130317093339.GT48089@FreeBSD.org> In-Reply-To: <51458691.4090107@freebsd.org> References: <201303170739.r2H7djP1098888@svn.freebsd.org> <51458691.4090107@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 17, 2013 at 10:02:09AM +0100, Andre Oppermann wrote: A> On 17.03.2013 08:39, Gleb Smirnoff wrote: A> > Author: glebius A> > Date: Sun Mar 17 07:39:45 2013 A> > New Revision: 248417 A> > URL: http://svnweb.freebsd.org/changeset/base/248417 A> > A> > Log: A> > Add MEXT_ALIGN() macro, similar to M_ALIGN() and MH_ALIGN(), but for A> > mbufs with external buffer. A> A> While you are cleaning up the mbuf usage wouldn't it make sense to remove A> these macros, instead of adding new ones, and use m_align() which handles A> all these cases internally? I'm thinking about this. Maybe it is worth to request tail alignment as a flag to the allocating function itself? -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130317093339.GT48089>