Date: Tue, 31 Dec 2002 21:12:21 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: "M. Warner Losh" <imp@bsdimp.com> Cc: ache@nagual.pp.ru, <phk@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sbin/fdisk fdisk.c Message-ID: <20021231203719.O50997-100000@gamplex.bde.org> In-Reply-To: <20021230.150152.04789006.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 30 Dec 2002, M. Warner Losh wrote: > In message: <20021230045437.GA54633@nagual.pp.ru> > "Andrey A. Chernov" <ache@nagual.pp.ru> writes: > : On Sun, Dec 29, 2002 at 07:17:11 -0800, Poul-Henning Kamp wrote: > : > phk 2002/12/29 07:17:11 PST > : > > : > Modified files: > : > sbin/fdisk fdisk.c > : > Log: > : > Make fdisk work on active GEOM devices. > : > > : > Revision Changes Path > : > 1.67 +33 -8 src/sbin/fdisk/fdisk.c > : > : Is there a chance to fix 'disklabel -B' in such manner too? > > Actually, disklabel -B needs different fixes, that green has posted > and I've tested... green seems to agree with me that these changes are not quite right. disklabel -B would have been easy enough to fix correctly until the recent hack of putting some of the boot blocks in the label sector combined with the older mistake of removing block devices. disklabel -B only needs to write to non-label areas, but this is now impossible because some of the boot blocks are in the label sector and only full blocks can be written using raw devices. disklabel -r is more fundamentally broken, and disklabel -B fails mainly because it implies -r. green's changes seem to do mainly the part that can be done correctly. I don't see how they can work now that part of the boot blocks is in the label sector. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021231203719.O50997-100000>