Date: Tue, 6 May 2014 06:37:29 -0500 From: Mark Felder <feld@FreeBSD.org> To: "Matthew D. Fuller" <fullermd@over-yonder.net> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r353008 - in head/security: clamav clamav-devel clamav-devel/files clamav/files Message-ID: <c383ed411cefb57d67af9c49da74c1d0@mail.feld.me> In-Reply-To: <20140506093123.GI7138@over-yonder.net> References: <201405051438.s45EcHQZ028890@svn.freebsd.org> <20140506093123.GI7138@over-yonder.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2014-05-06 04:31, Matthew D. Fuller wrote: > On Mon, May 05, 2014 at 02:38:17PM +0000 I heard the voice of > Mark Felder, and lo! it spake thus: >> Author: feld >> Date: Mon May 5 14:38:17 2014 >> New Revision: 353008 >> URL: http://svnweb.freebsd.org/changeset/ports/353008 >> QAT: https://qat.redports.org/buildarchive/r353008/ >>=20 >> Log: >> rc script spring cleaning -- now passes rclint >=20 > I think you accidentally swept the stove outside :) >=20 >> Modified: head/security/clamav-devel/files/clamav-milter.in >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > [...] >> +: ${clamav_milter_flags=3D"-c ${conf_file}"} > [...] >> conf_file=3D%%PREFIX%%/etc/clamav-milter.conf > [...] >> -: ${clamav_milter_flags=3D"-c ${conf_file}"} >=20 > This is now winding up with ${conf_file} being used before defined, > making the startup process drop a hairball at my feet... Nice catch. Neither Garga nor myself have ever used clamav-milter and=20 didn't have a test environment to catch what our eyes did not...=20 definitely threw the baby out with the bath water there. Thanks for the heads up!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c383ed411cefb57d67af9c49da74c1d0>