Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 22 Jun 2014 21:14:34 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r267748 - stable/10/sys/kern
Message-ID:  <201406222114.s5MLEYnZ074289@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mav
Date: Sun Jun 22 21:14:34 2014
New Revision: 267748
URL: http://svnweb.freebsd.org/changeset/base/267748

Log:
  MFC r267362:
  Remove unneeded mountlist_mtx acquisition from sync_fsync().
  
  All struct mount fields accessed by sync_fsync() are protected by MNT_MTX.

Modified:
  stable/10/sys/kern/vfs_subr.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/kern/vfs_subr.c
==============================================================================
--- stable/10/sys/kern/vfs_subr.c	Sun Jun 22 20:29:51 2014	(r267747)
+++ stable/10/sys/kern/vfs_subr.c	Sun Jun 22 21:14:34 2014	(r267748)
@@ -3654,11 +3654,8 @@ sync_fsync(struct vop_fsync_args *ap)
 	 * Walk the list of vnodes pushing all that are dirty and
 	 * not already on the sync list.
 	 */
-	mtx_lock(&mountlist_mtx);
-	if (vfs_busy(mp, MBF_NOWAIT | MBF_MNTLSTLOCK) != 0) {
-		mtx_unlock(&mountlist_mtx);
+	if (vfs_busy(mp, MBF_NOWAIT) != 0)
 		return (0);
-	}
 	if (vn_start_write(NULL, &mp, V_NOWAIT) != 0) {
 		vfs_unbusy(mp);
 		return (0);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201406222114.s5MLEYnZ074289>