Date: Mon, 20 May 2024 12:15:46 -0400 From: mike tancsa <mike@sentex.net> To: Mike Karels <mike@karels.net> Cc: FreeBSD Net <freebsd-net@freebsd.org> Subject: Re: networking in 14.1 release notes Message-ID: <f6bdbf1d-ae5a-471b-90a0-ac483c0a4f42@sentex.net> In-Reply-To: <05E86D91-8B06-4B48-ADAA-68FC1927DA36@karels.net> References: <7C2C0681-C1D1-404F-8B09-E65C29E366D3@karels.net> <ec1d7e1d-0fac-4426-92ba-72406f747f6b@sentex.net> <7751A3C8-BAAA-4E67-9725-5A3A6A8793F1@karels.net> <54c5ee01-06fa-4073-8a06-a68f2f5cffcf@sentex.net> <05E86D91-8B06-4B48-ADAA-68FC1927DA36@karels.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------QBK0cxE5Gr0an7Eihk8SQZe3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 5/20/2024 11:54 AM, Mike Karels wrote: > That sounds like an outright bug. Looks like it was true in 14.0 as well. >>> Is there a bug report? I couldn't find one. >> I didnt open one. Wasnt sure if it the change was a deliberate one or on the wrong side of POLA. To me it feels unnecessary to have only one order of params but I might be missing the rational behind it. Shall I open a PR ? > Yes, please. I looked into it yesterday; it looks accidental. I'll follow up. Thanks Mike! PR opened https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279181 ---Mike --------------QBK0cxE5Gr0an7Eihk8SQZe3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit <!DOCTYPE html> <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body> <div class="moz-cite-prefix">On 5/20/2024 11:54 AM, Mike Karels wrote:<br> </div> <blockquote type="cite" cite="mid:05E86D91-8B06-4B48-ADAA-68FC1927DA36@karels.net"><span style="white-space: pre-wrap">That sounds like an outright bug. Looks like it was true in 14.0 as well.</span> <blockquote type="cite"> <blockquote type="cite"> <pre class="moz-quote-pre" wrap="">Is there a bug report? I couldn't find one. </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> I didnt open one. Wasnt sure if it the change was a deliberate one or on the wrong side of POLA. To me it feels unnecessary to have only one order of params but I might be missing the rational behind it. Shall I open a PR ? </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> Yes, please. I looked into it yesterday; it looks accidental. I'll follow up. </pre> </blockquote> <p>Thanks Mike! PR opened <a class="moz-txt-link-freetext" href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279181">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279181</a></p> <p> ---Mike<br> </p> <p><br> </p> <blockquote type="cite" cite="mid:05E86D91-8B06-4B48-ADAA-68FC1927DA36@karels.net"> <pre class="moz-quote-pre" wrap=""> </pre> </blockquote> </body> </html> --------------QBK0cxE5Gr0an7Eihk8SQZe3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f6bdbf1d-ae5a-471b-90a0-ac483c0a4f42>