Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 25 Jun 2014 13:58:29 +0200
From:      Attilio Rao <attilio@freebsd.org>
To:        =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <royger@freebsd.org>,  Alan Cox <alc@freebsd.org>
Cc:        "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>
Subject:   Re: svn commit: r267858 - in head/sys/dev: virtio/balloon xen/balloon
Message-ID:  <CAJ-FndD4M8QkejyTv4R_9qoThqvFinYbHP4YSby6mQS9EKSYPA@mail.gmail.com>
In-Reply-To: <201406250951.s5P9p8YR017159@svn.freebsd.org>
References:  <201406250951.s5P9p8YR017159@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 25, 2014 at 11:51 AM, Roger Pau Monn=C3=A9 <royger@freebsd.org>=
 wrote:
> Author: royger
> Date: Wed Jun 25 09:51:08 2014
> New Revision: 267858
> URL: http://svnweb.freebsd.org/changeset/base/267858
>
> Log:
>   xen/virtio: fix balloon drivers to not mark pages as WIRED
>
>   Prevent the Xen and VirtIO balloon drivers from marking pages as
>   wired. This prevents them from increasing the system wired page count,
>   which can lead to mlock failing because of hitting the limit in
>   vm.max_wired.

This change is conceptually wrong.
The pages balloon is allocating are unmanaged and they should be wired
by definition. Alan and I are considering enforcing this (mandatory
wired pages for unmanaged pages allocation) directly in the KPI.
This in practice just seem an artifact to deal with scarce  wired
memory limit. I suggest that for the XEN case this limit gets bumped
rather relying on similar type of hacks.

Attilio


--=20
Peace can only be achieved by understanding - A. Einstein



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-FndD4M8QkejyTv4R_9qoThqvFinYbHP4YSby6mQS9EKSYPA>