Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 22 Jan 2011 16:28:50 +0000
From:      Chris Rees <utisoft@gmail.com>
To:        Jan Henrik Sylvester <me@janh.de>
Cc:        ports-list freebsd <freebsd-ports@freebsd.org>
Subject:   Re: Xournal: Please, help me with my first port
Message-ID:  <AANLkTikfWUSXoH6QOkZ=z43CvhDsTy_hZPfToM1tgMTN@mail.gmail.com>
In-Reply-To: <4D3AF40E.7090301@janh.de>
References:  <4D39FEBA.3000806@janh.de> <AANLkTimSe3wBQ_FPdfDtgcLH-bDXsDfX2AZ3hsD5Xff4@mail.gmail.com> <AANLkTinU4rCAhgW2=3eNTPgPdftPDn8KiBF_ORGmVqtX@mail.gmail.com> <4D3AF40E.7090301@janh.de>

next in thread | previous in thread | raw e-mail | index | archive | help
On 22 January 2011 15:13, Jan Henrik Sylvester <me@janh.de> wrote:
>>> The DATADIR whines are addressed in this patch, have a look:
>>>
>>> http://www.bayofrum.net/~chris/patches/xournal-pkg-plist.diff
>
> Thanks, but since the port does not honor DATADIR, it should not be there --
> or the DATADIR case must be fixed first.

Addressed below.

>
>>> That's all I had time to look at at the moment, perhaps others can help!
>>>
>>
>> Alright, came back and now the patch has the desktop-install target
>> defined instead of using the post-install. This is reflected in the
>> patch linked above ^^^
>
> Thanks, I was looking for something like that, but it should be
> "INSTALL_TARGET= install desktop-install", because desktop-install does not
> include install.

Certainly. Looks as though we should define the do-install: target
rather than rely
on the provided ones; this means that we can make the port DATADIR safe. I'll
look shortly.

>
>> I've stuck it in my Tinderbox for testing, follow it here:
>> http://tinderbox.bayofrum.net/index.php?action=describe_port&id=196
>
> Thanks!
>
> I do not know Tinderbox enough to understand, why your mkfontscale build
> tried to install an outdated version of freetype2.
>

Because I was an idiot and forgot to update the ports tree before
starting the build ><

Chris



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTikfWUSXoH6QOkZ=z43CvhDsTy_hZPfToM1tgMTN>