Skip site navigation (1)Skip section navigation (2) 
Date:      Thu, 7 Jan 2016 04:43:51 -0800
From:      David Wolfskill <david@catwhisker.org>
To:        "O. Hartmann" <ohartman@zedat.fu-berlin.de>
Cc:        freebsd-current <freebsd-current@freebsd.org>
Subject:   Re: r 293304: BROKEN: buildkernel fails due to error: error: no member named 't_maxopd' in 'struct tcpcb'
Message-ID:  <20160107124351.GS2781@albert.catwhisker.org>
In-Reply-To: <20160107063111.0a4e232f@freyja.zeit4.iv.bundesimmobilien.de>
References:  <20160107063111.0a4e232f@freyja.zeit4.iv.bundesimmobilien.de>
next in thread | previous in thread | raw e-mail | index | archive | help 

--J9aX9M0sKuxf6dAJ
Content-Type: multipart/mixed; boundary="EuZYeicfAhUaxfGJ"
Content-Disposition: inline


--EuZYeicfAhUaxfGJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 07, 2016 at 06:31:11AM +0100, O. Hartmann wrote:
> Recent r293304 fails to build kernel due to the error below:
>=20
> [...]
> --- kern_testfrwk.o ---
> cc  -O2 -pipe -O3 -O3 -pipe -march=3Dnative  -fno-strict-aliasing -Werror
> -D_KERNEL -DKLD_MODULE -nostdinc   -DHAVE_KERNEL_OPTION_HEADERS
> -include /usr/obj/usr/src/sys/FREYJA/opt_global.h -I. -I/usr/src/sys
> -fno-common  -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer
> -I/usr/obj/usr/src/sys/FREYJA  -mcmodel=3Dkernel -mno-red-zone -mno-mmx -=
mno-sse
> -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv
> -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-proto=
types
> -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef
> -Wno-pointer-sign -D__printf__=3D__freebsd_kprintf__  -Wmissing-include-d=
irs
> -fdiagnostics-show-option  -Wno-unknown-pragmas
> -Wno-error-tautological-compare -Wno-error-empty-body
> -Wno-error-parentheses-equality -Wno-error-unused-function
> -Wno-error-pointer-sign -Wno-error-shift-negative-value  -mno-aes -mno-avx
> -std=3Diso9899:1999
> -c /usr/src/sys/modules/tests/framework/../../../tests/framework/kern_tes=
tfrwk.c
> -o kern_testfrwk.o --- all_subdir_tcp/fastpath
> --- /usr/src/sys/modules/tcp/fastpath/../../../netinet/tcp_stacks/fastpat=
h.c:481:6:
> error: no member named 't_maxopd' in 'struct tcpcb' if (DELAY_ACK(tp, tle=
n))
> { ^
> ~~ /usr/src/sys/modules/tcp/fastpath/../../../netinet/tcp_stacks/fastpath=
=2Ec:167:19:
> note: expanded from macro 'DELAY_ACK' (tlen <=3D tp->t_maxopd)
> &&                                   \
> ^ /usr/src/sys/modules/tcp/fastpath/../../../netinet/tcp_stacks/fastpath.=
c:606:8:
> error: no member named 't_maxopd' in 'struct tcpcb' if (DELAY_ACK(tp, tle=
n) &&
> tlen !=3D 0) ^
> ~~ /usr/src/sys/modules/tcp/fastpath/../../../netinet/tcp_stacks/fastpath=
=2Ec:167:19:
> note: expanded from macro 'DELAY_ACK' (tlen <=3D tp->t_maxopd)
> &&                                   \ ^ --- sctp_indata.o --- ctfconvert=
 -L
> VERSION sctp_indata.o ERROR: ctfconvert: sctp_indata.o doesn't have type =
data
> to convert --- modules-all --- --- all_subdir_sfxge --- --- siena_vpd.o -=
-- cc
> -O2 -pipe -O3 -O3 -pipe -march=3Dnative  -fno-strict-aliasing -Werror -D_=
KERNEL
> -DKLD_MODULE -nostdinc   -DHAVE_KERNEL_OPTION_HEADERS
> -include /usr/obj/usr/src/sys/FREYJA/opt_global.h -I. -I/usr/src/sys
> -fno-common  -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer
> -I/usr/obj/usr/src/sys/FREYJA  -mcmodel=3Dkernel -mno-red-zone -mno-mmx -=
mno-sse
> -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv
> -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-proto=
types
> -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef
> -Wno-pointer-sign -D__printf__=3D__freebsd_kprintf__  -Wmissing-include-d=
irs
> -fdiagnostics-show-option  -Wno-unknown-pragmas
> -Wno-error-tautological-compare -Wno-error-empty-body
> -Wno-error-parentheses-equality -Wno-error-unused-function
> -Wno-error-pointer-sign -Wno-error-shift-negative-value  -mno-aes -mno-avx
> -std=3Diso9899:1999
> -c /usr/src/sys/modules/sfxge/../../dev/sfxge/common/siena_vpd.c -o siena=
_vpd.o
> --- all_subdir_tcp/fastpath
> --- /usr/src/sys/modules/tcp/fastpath/../../../netinet/tcp_stacks/fastpat=
h.c:1545:8:
> error: no member named 't_maxopd' in 'struct tcpcb' if (DELAY_ACK(tp, tle=
n))
> ^
> ~~ /usr/src/sys/modules/tcp/fastpath/../../../netinet/tcp_stacks/fastpath=
=2Ec:167:19:
> note: expanded from macro 'DELAY_ACK' (tlen <=3D tp->t_maxopd)
> &&                                   \ ^ 3 errors generated. *** [fastpat=
h.o]
> Error code 1
>=20
> make[4]: stopped in /usr/src/sys/modules/tcp/fastpath
> 1 error
>=20
> make[4]: stopped in /usr/src/sys/modules/tcp/fastpath
> *** [all_subdir_tcp/fastpath] Error code 2
>=20
> make[3]: stopped in /usr/src/sys/modules
> --- all_subdir_sfxge ---
> --- siena_sram.o ---
> ctfconvert -L VERSION siena_sram.o
> ERROR: ctfconvert: siena_sram.o doesn't have type data to convert
> --- all_subdir_tests/callout_test ---
> ctfconvert -L VERSION callout_test.o
> ERROR: ctfconvert: callout_test.o doesn't have type data to convert
> A failure has been detected in another branch of the parallel make
>=20
> make[4]: stopped in /usr/src/sys/modules/tests/callout_test
> *** [all_subdir_tests/callout_test] Error code 2
>=20
> make[3]: stopped in /usr/src/sys/modules
> --- sctp_input.o ---
> ctfconvert -L VERSION sctp_input.o
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"

The attached patch gets through the buildkernel.  After install &
reboot, I'm not seeing obvious issues -- I can still talk to the box
over TCP, at least.

Peace,
david
--=20
David H. Wolfskill				david@catwhisker.org
Those who would murder in the name of God or prophet are blasphemous coward=
s.

See http://www.catwhisker.org/~david/publickey.gpg for my public key.

--EuZYeicfAhUaxfGJ
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="fastpath.c.patch"
Content-Transfer-Encoding: quoted-printable

Index: sys/netinet/tcp_stacks/fastpath.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- sys/netinet/tcp_stacks/fastpath.c	(revision 293312)
+++ sys/netinet/tcp_stacks/fastpath.c	(working copy)
@@ -164,7 +164,7 @@
 #define DELAY_ACK(tp, tlen)						\
 	((!tcp_timer_active(tp, TT_DELACK) &&				\
 	    (tp->t_flags & TF_RXWIN0SENT) =3D=3D 0) &&			\
-	    (tlen <=3D tp->t_maxopd) &&					\
+	    (tlen <=3D tp->t_maxseg) &&					\
 	    (V_tcp_delack_enabled || (tp->t_flags & TF_NEEDSYN)))
=20
 /*

--EuZYeicfAhUaxfGJ--

--J9aX9M0sKuxf6dAJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQF8BAEBCgBmBQJWjl2HXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRDQ0I3Q0VGOTE3QTgwMUY0MzA2NEQ3N0Ix
NTM5Q0M0MEEwNDlFRTE3AAoJEBU5zECgSe4Xnj0H/j62isk1q2Zb+lAOB3Iwl0/d
BPixEji2g96+9beHeNia1XcFiZz3pZlCIhbQCZOHfSGxnRp8sL5ydcrOtrZhEB04
ale/uWwzJWFSZfrxDRFhS0VFafO+HQ6Q2qISw3GTDcpTf94FicxiFvPMR4fJkpBC
OI9/a0NVdAEFDE7bkFRz0LXIu8w9K3CDBj9hzNUcZeOZipXxgF9qZMEG+DIJKj7n
88NdrZ1lKOfufRBMyi2Nvn6kEjf0ys5zNrU2wEFo6Hi+Ku29HDc9xwwdJXwLpMli
bQ3L4PL53sQJeMc3crA2LNhGaSlRK3R6AqQfSXx/pdVFgjMwVaV9IbgJYnlc8m4=
=pbSK
-----END PGP SIGNATURE-----

--J9aX9M0sKuxf6dAJ--

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160107124351.GS2781>