Date: Fri, 13 Aug 2010 14:00:18 GMT From: "b. f." <bf1783@googlemail.com> To: freebsd-python@FreeBSD.org Subject: Re: ports/136917: [patch] lang/python26: gettext detection Message-ID: <201008131400.o7DE0I7A033802@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/136917; it has been noted by GNATS.
From: "b. f." <bf1783@googlemail.com>
To: bug-followup@FreeBSD.org
Cc: Anonymous <swell.k@gmail.com>
Subject: Re: ports/136917: [patch] lang/python26: gettext detection
Date: Fri, 13 Aug 2010 13:56:45 +0000
> +.if defined(CPPFLAGS)
> +CONFIGURE_ENV+= CPPFLAGS="${CPPFLAGS}"
> +.endif
> +.if defined(LDFLAGS)
> +CONFIGURE_ENV+= LDFLAGS="${LDFLAGS}"
> +.endif
You need to perform these tests after all additions to CPPFLAGS and
LDFLAGS via OPTIONS, or add both of them unconditionally to the
CONFIGURE_ENV= ... line before the inclusion of bsd.port.pre.mk. The
latter is the usual approach. The way you have it now, if there
aren't user-defined CPPFLAGS or some other intervention, CPPFLAGS
won't be added to CONFIGURE_ENV, even if WITH_THREADS and
WITH_PTH=true, because CPPFLAGS won't have been defined when the test
is performed. Anyway, LDFLAGS is almost always defined, though it may
be empty, via /usr/share/mk/sys.mk. And note that, although I don't
think it matters for this port, prepending a value to these flags (as
in the current port Makefile) may not have the same effect as
appending a value with += (as in your patched version) because, in
general, search order matters.
b.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201008131400.o7DE0I7A033802>